Attempt to remove the special JpegStream.getBytes method and utilize the regular DecodeStream one instead
#9260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the regular `DecodeStream` one instead
Note that no other image stream implements a special `getBytes` method, which makes `JpegStream` look somewhat odd.
I'm actually not sure what purpose this methods serves, since I successfully ran all tests locally with it commented out. Furhermore, I also ran tests with an added `if (length && length !== this.bufferLength) { throw new Error('length mismatch'); }` check, and didn't get a single test failure in that case either.
Looking at the history, it seems that this code originated back in PR 4528, but as far as I can tell there's no mention in either commit messages nor PR comments of why it was necessary to add a "special" `getBytes` function for the `JpegStream`.
My assumption is that there's a good reason why this method was added, e.g. to address a *specific* regression in one of the reference tests. However, I did check out commit 58f697f locally and ran tests with this method commented out, and there didn't seem to be any image-related failures in that case either!?
Hence I'm suggesting that we attempt to simplify this code slightly be removing this special `getBytes` method. However, please note that there's perhaps a *small* risk of regressions in an edge-case where we currently have insufficient test-coverage.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/86ba77e7ed37752/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/5713a0a90a42415/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/86ba77e7ed37752/output.txt Total script time: 17.01 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/5713a0a90a42415/output.txt Total script time: 23.39 mins
|
timvandermeij
approved these changes
Dec 10, 2017
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
…ytes Attempt to remove the special `JpegStream.getBytes` method and utilize the regular `DecodeStream` one instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that no other image stream implements a special
getBytesmethod, which makesJpegStreamlook somewhat odd.I'm actually not sure what purpose this methods serves, since I successfully ran all tests locally with it commented out. Furthermore, I also ran tests with an added
if (length && length !== this.bufferLength) { throw new Error('length mismatch'); }check, and didn't get a single test failure in that case either.Looking at the history, it seems that this code originated back in PR #4528, but as far as I can tell there's no mention in either commit messages nor PR comments of why it was necessary to add a "special"
getBytesfunction for theJpegStream.My assumption is that there's a good reason why this method was added, e.g. to address a specific regression in one of the reference tests. However, I did check out commit 58f697f locally and ran tests with this method commented out, and there didn't seem to be any image-related failures in that case either!?
Hence I'm suggesting that we attempt to simplify this code slightly be removing this special
getBytesmethod. However, please note that there's perhaps a small risk of regressions in an edge-case where we currently have insufficient test-coverage.