-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid truncating JPEG images with DeviceGray ColourSpaces when using the src/core/jpg.js
built-in decoder
#9327
Avoid truncating JPEG images with DeviceGray ColourSpaces when using the src/core/jpg.js
built-in decoder
#9327
Conversation
…the `src/core/jpg.js` built-in decoder The bug that this patch fixes is limited to the built-in JPEG decoder, and was unearthed by PR 9260. The underlying issue has existed since PR 6984, where the contents of this patch ought to have been included (if it weren't for the fact that we had no *easy* way to test `src/core/jpg.js` back then). *Please note:* The slight movement in the reference test is a result of using the `src/core/jpg.js` decoder, rather than the native browser one.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/175edd93c15f1e5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/efd775917c81b69/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/175edd93c15f1e5/output.txt Total script time: 17.41 mins
Image differences available at: http://54.67.70.0:8877/175edd93c15f1e5/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/efd775917c81b69/output.txt Total script time: 23.17 mins
Image differences available at: http://54.215.176.217:8877/efd775917c81b69/reftest-analyzer.html#web=eq.log |
src/core/jpg.js
built-in decodersrc/core/jpg.js
built-in decoder
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c91e7c90bd4f10b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/6df5034bafab2af/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c91e7c90bd4f10b/output.txt Total script time: 16.27 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/6df5034bafab2af/output.txt Total script time: 21.16 mins
|
Thank you for fixing this! |
…ray-length Avoid truncating JPEG images with DeviceGray ColourSpaces when using the `src/core/jpg.js` built-in decoder
The bug that this patch fixes is limited to the built-in JPEG decoder, and was unearthed by PR #9260. The underlying issue has existed since PR #6984, where the contents of this patch ought to have been included (if it weren't for the fact that we had no easy way to test
src/core/jpg.js
back then).Please note: The slight movement in the reference test is a result of using the
src/core/jpg.js
decoder, rather than the native browser one.