Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid truncating JPEG images with DeviceGray ColourSpaces when using the src/core/jpg.js built-in decoder #9327

Merged
merged 1 commit into from
Dec 29, 2017
Merged

Avoid truncating JPEG images with DeviceGray ColourSpaces when using the src/core/jpg.js built-in decoder #9327

merged 1 commit into from
Dec 29, 2017

Conversation

Snuffleupagus
Copy link
Collaborator

The bug that this patch fixes is limited to the built-in JPEG decoder, and was unearthed by PR #9260. The underlying issue has existed since PR #6984, where the contents of this patch ought to have been included (if it weren't for the fact that we had no easy way to test src/core/jpg.js back then).

Please note: The slight movement in the reference test is a result of using the src/core/jpg.js decoder, rather than the native browser one.

…the `src/core/jpg.js` built-in decoder

The bug that this patch fixes is limited to the built-in JPEG decoder, and was unearthed by PR 9260. The underlying issue has existed since PR 6984, where the contents of this patch ought to have been included (if it weren't for the fact that we had no *easy* way to test `src/core/jpg.js` back then).

*Please note:* The slight movement in the reference test is a result of using the `src/core/jpg.js` decoder, rather than the native browser one.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/175edd93c15f1e5/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/efd775917c81b69/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/175edd93c15f1e5/output.txt

Total script time: 17.41 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/175edd93c15f1e5/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.215.176.217:8877/efd775917c81b69/output.txt

Total script time: 23.17 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/efd775917c81b69/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus changed the title Avoid truncating JPEG images with DeviceGray ColourSpaces when using he src/core/jpg.js built-in decoder Avoid truncating JPEG images with DeviceGray ColourSpaces when using the src/core/jpg.js built-in decoder Dec 29, 2017
@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c91e7c90bd4f10b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/6df5034bafab2af/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/c91e7c90bd4f10b/output.txt

Total script time: 16.27 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/6df5034bafab2af/output.txt

Total script time: 21.16 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij merged commit ad0dc7e into mozilla:master Dec 29, 2017
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

@Snuffleupagus Snuffleupagus deleted the JpegStream-DeviceGray-length branch December 30, 2017 11:39
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
…ray-length

Avoid truncating JPEG images with DeviceGray ColourSpaces when using the `src/core/jpg.js` built-in decoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants