Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce binaries size #798

Merged
merged 2 commits into from
Mar 4, 2022
Merged

Reduce binaries size #798

merged 2 commits into from
Mar 4, 2022

Conversation

Luni-4
Copy link
Collaborator

@Luni-4 Luni-4 commented Mar 4, 2022

This PR fixes #430

With the new Rust 1.59 version, it is possible to strip standard library debug symbols directly from Cargo

Luni-4 added 2 commits March 4, 2022 10:55
With the new Rust 1.59 version, it is possible to strip standard library
debug symbols directly from Cargo
This update is necessary to support the new Rust strip option
@Luni-4 Luni-4 requested a review from marco-c March 4, 2022 10:32
@codecov-commenter
Copy link

Codecov Report

Merging #798 (caaa0b7) into master (98538cb) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #798      +/-   ##
==========================================
+ Coverage   39.63%   39.94%   +0.30%     
==========================================
  Files          51       51              
  Lines        6827     6827              
  Branches      975      975              
==========================================
+ Hits         2706     2727      +21     
+ Misses       3453     3439      -14     
+ Partials      668      661       -7     
Impacted Files Coverage Δ
src/metrics/nargs.rs 74.80% <0.00%> (+0.38%) ⬆️
src/metrics/nom.rs 73.15% <0.00%> (+0.52%) ⬆️
src/spaces.rs 72.56% <0.00%> (+1.21%) ⬆️
src/getter.rs 80.43% <0.00%> (+3.91%) ⬆️
src/node.rs 86.53% <0.00%> (+15.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98538cb...caaa0b7. Read the comment docs.

@marco-c marco-c merged commit 62667c6 into master Mar 4, 2022
@marco-c marco-c deleted the reduce-binary branch March 4, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce Linux and Windows binaries size
3 participants