-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump mkdirp from 1.0.4 to 3.0.1 #2735
Conversation
8a94a28
to
5532ecb
Compare
5532ecb
to
621fba2
Compare
@dependabot rebase |
Bumps [mkdirp](https://github.com/isaacs/node-mkdirp) from 1.0.4 to 3.0.1. - [Release notes](https://github.com/isaacs/node-mkdirp/releases) - [Changelog](https://github.com/isaacs/node-mkdirp/blob/main/CHANGELOG.md) - [Commits](isaacs/node-mkdirp@v1.0.4...v3.0.1) --- updated-dependencies: - dependency-name: mkdirp dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
621fba2
to
023c852
Compare
@@ -6,7 +6,7 @@ | |||
import path from 'path'; | |||
|
|||
import fs from 'fs-extra'; | |||
import asyncMkdirp from 'mkdirp'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willdurand this (and the similar tweak in artifacts.js) is the only change needed to fix the test failure (the changelog also confirms that mkdirp is not only exposing a named export).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2735 +/- ##
==========================================
+ Coverage 99.52% 99.53% +0.01%
==========================================
Files 32 32
Lines 1686 1735 +49
==========================================
+ Hits 1678 1727 +49
Misses 8 8 ☔ View full report in Codecov by Sentry. |
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Luca Greco <lgreco@mozilla.com> Co-authored-by: William Durand <will+git@drnd.me>
Bumps mkdirp from 1.0.4 to 3.0.1.
Changelog
Sourced from mkdirp's changelog.
Commits
6fc2977
3.0.1348e179
bring back other named exports06dfe55
3.0.005861a5
Remove default export, named exports onlyadabb30
2.1.635aa15d
add map stuff to tsconfiga2d14cf
2.1.517715e0
export correct types, at top lvl and in require exportsa7886fc
2.1.4bafbf7f
add declarationMap to tsconfigYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)