Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump mkdirp from 1.0.4 to 3.0.1 #2735

Merged
merged 4 commits into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"https-proxy-agent": "^7.0.0",
"jose": "5.4.0",
"jszip": "3.10.1",
"mkdirp": "1.0.4",
"mkdirp": "3.0.1",
"multimatch": "6.0.0",
"mz": "2.7.0",
"node-fetch": "3.3.2",
Expand Down
2 changes: 1 addition & 1 deletion src/extension-runners/chromium.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import path from 'path';

import fs from 'fs-extra';
import asyncMkdirp from 'mkdirp';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willdurand this (and the similar tweak in artifacts.js) is the only change needed to fix the test failure (the changelog also confirms that mkdirp is not only exposing a named export).

import { mkdirp as asyncMkdirp } from 'mkdirp';
import {
Launcher as ChromeLauncher,
launch as defaultChromiumLaunch,
Expand Down
2 changes: 1 addition & 1 deletion src/util/artifacts.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { fs } from 'mz';
import defaultAsyncMkdirp from 'mkdirp';
import { mkdirp as defaultAsyncMkdirp } from 'mkdirp';

import { UsageError, isErrorWithCode } from '../errors.js';
import { createLogger } from './logger.js';
Expand Down