src_main: Add libm link for xevd_dynamic #70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We run into the following error when building ffmpeg with xevd support unless we explicitly pass
-lm
in CFLAGS:With help I've tracked this down to
src_main/CMakeLists.txt
specifyingtarget_link_libraries(${LIB_NAME} m)
only for the static library target and not the shared library.By specifying the dependency for the shared library too the resulting
libxevd.so
contains a proper reference to alibm.so
, which means downstream doesn't need to provide-lm
.