Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src_main: Add libm link for xeve_dynamic #132

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

toonn
Copy link
Contributor

@toonn toonn commented Jul 26, 2024

Basically the same PR as mpeg5/xevd#70.

We run into the following error when building ffmpeg with xeve support unless we explicitly pass -lm in CFLAGS:

ERROR: xevd >= 0.4.1 not found using pkg-config

If you think configure made a mistake, make sure you are using the latest
version from Git.  If the latest version fails, report the problem to the
ffmpeg-user@ffmpeg.org mailing list or IRC #ffmpeg on irc.libera.chat.
Include the log file "ffbuild/config.log" produced by configure as this will help
solve the problem.

With help I've tracked this down to src_main/CMakeLists.txt specifying target_link_libraries(${LIB_NAME} m) only for the static library target and not the shared library.

By specifying the dependency for the shared library too the resulting libxeve.so contains a proper reference to a libm.so, which means downstream doesn't need to provide -lm.

@dariusz-f dariusz-f merged commit 954ed6e into mpeg5:master Jul 29, 2024
6 checks passed
@toonn toonn mentioned this pull request Jul 29, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants