input: implement VO dragging deadzone #14251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not supported anymore.
Will be used for the VO dragging deadzone.
The stored mouse position mouse_vo_x/y are scaled (currently only for vo_xv), but the position equality check compares between raw position and scaled position. Fix this by storing and checking the raw position instead. The raw position is useful for the next commit.
|
Download the artifacts for this pull request: |
na-na-hi
force-pushed
the
vo-dragging-deadzone
branch
from
bf671e5
to
e85928a
Compare
This adds the --input-dragging-deadzone option, which adds a deadzone for the built-in VO deagging. This prevents accidental VO dragging.
Currently, the built-in VO dragging conflicts with the MBTN_LEFT binding, so the binding is activated even though the VO dragging begins. Fix this by releasing the currently down command so that MBTN_LEFT can be bound to a useful action (such as play/pause).
This adds the --input-builtin-dragging option, which allows the built-in dragging behavior to be disabled. This allows scripts to implement custom dragging behavior with left button down events and begin-vo-dragging command, which could only be done for other mouse buttons before.
This prevents doubleclick from activation if a second mouse click comes quickly after a click which begins dragging.
na-na-hi
force-pushed
the
vo-dragging-deadzone
branch
from
e85928a
to
e72273e
Compare
kasper93
reviewed
Jun 3, 2024
kasper93
approved these changes
Jun 4, 2024
|
It breaks OSC seekbar mouse dragging, both osc.lua uosc and mpv-osc-modern are affected. |
Should be fixed by #14301. |
|
Why conflict with MBTN_LEFT script binding. mp.add_forced_key_binding('MBTN_LEFT', 'MBTN_LEFT', function() mp.commandv('cycle', 'pause') end) |
There is a bug with key bindings registered by scripts which are incorrectly triggered if the command is canceled. #14311 fixes this.
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several problems with VO dragging:
--input-dragging-deadzoneoption, which adds a deadzone for the built-in VO dragging.MBTN_LEFTbinding.Fixes #7563.
Fixes #13225.
Fixes #13958.
Fixes #14248.