Binary payloads not supported?

[hudgins]

I might be missing something, but it seems binary payloads are not supported because of this line, where we are converting the buffer to a utf8 string:

https://github.com/adamvr/MQTT.js/blob/master/lib/parse.js#L122

Leaving it as a buffer solves my problem, eg:

packet.payload = buf.slice(pos, len);

What is the thinking here? A simple test like so reproduces the problem:

var fs = require('fs');
var mqtt = require('mqtt');
var client = mqtt.createClient();

client.subscribe('buffer');

client.on('message', function(topic, message) {
  console.log('received message on topic', topic);
  fs.writeFile('./file.bin', message);
});

fs.readFile(process.argv[2], function(err, buffer) {
  client.publish('buffer', buffer);
});

[carlhoerberg]

agree, the user should do the encoding/decoding

[tanpinsiang]

I also run into this problem, maybe provide an option for the user to get binary payloads.

[adamvr]

Yeah, this was just a cut corner to get things working quickly. Perhaps a setEncoding method on Connection?

[hudgins]

I see, makes sense. Turns out I habitually send stringified JSON when not sending binary, and apparently JSON.parse() can handle a Buffer containing a string.

[wolfeidau]

So is there an example or test using an encoding other than utf8? I am trying to send binary messages.

Basically want to try out msgpack.

Cheers

[wolfeidau]

OK

I found it.

    client = mqtt.createClient({encoding: 'binary'});

If you like I will update the readme and add a test.

[mcollina]

Please do so! Thanks a million!

Il giorno lunedì 2 settembre 2013, Mark Wolfe ha scritto:

OK

I found it.

client = mqtt.createClient({encoding: 'binary'});

If you like I will update the readme and add a test.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/109#issuecomment-23654639
.