Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set encoding on v0.3.0 #123

Merged
merged 6 commits into from
Aug 15, 2013
Merged

Set encoding on v0.3.0 #123

merged 6 commits into from
Aug 15, 2013

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Aug 8, 2013

This is #111 ported on top of the new parser.

It is a fast fix for #109.

@adamvr for backward compatibility I have put a default on the Connection object to decode stuff as utf8.

I still need to run some benches to check if that call() is a problem.

@mcollina
Copy link
Member Author

mcollina commented Aug 8, 2013

Right now the syntax for not encoding is setEnconding(null), which I do not like.

I'll say we can move it to setEncoding('binary').

@mcollina mcollina merged commit 9cda036 into v0.3.0-dev Aug 15, 2013
@adamvr
Copy link
Member

adamvr commented Aug 15, 2013

👍 setEncoding(null) was super ugly.

@simoneb simoneb mentioned this pull request Jun 17, 2014
@YoDaMa YoDaMa deleted the set-encoding-v0.3.0 branch May 11, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants