-
-
Notifications
You must be signed in to change notification settings - Fork 35.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflector/Refractor: Add multisampling support. #23444
Conversation
Thanks! |
Regarding What do you think about removing that class and adding a |
We also have to move However, after all it's probably best to head for this change since starting with WebGL 2 multisampling is a common thing for all render targets. |
Exactly. |
I'll take a look 👍 . |
@vanruesc yes, one step at a time though... 🤓 |
Related issue: #22933
Description
Introducing multisampling support to
Reflector
andRefractor
.I've noticed there are multiple ways how
three.js
currently names variables/properties which define how many samples are used in context of multisampling:WebGLMultisampleRenderTarget
is currently usingsamples
.multisample
which is used in this PR, too.WebGPURenderer
usesampleCount
.If I had to make a choice I would pick
sampleCount
although the others are of course good, too. We should just ensure to use the same syntax everywhere.