Fix invalid snippet insertion when using "Find Inplace" #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The video can't be played. It just shows an error message that the file is corrupt. (I'm on Firefox on macOS.) |
mre
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage of
vscode.SnippetStringfor inserting snippets to the document is resulting in parts of the text of type${some_text}being removed (https://code.visualstudio.com/api/references/vscode-api#SnippetString).For example, if the user opens .js file, selects "Find inplace" and enters "interpolation string", this line of code:
will become:
Instead, the snippets should be pasted as-is.
video_00000.mp4