Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json: Refer to micromatch 4.0.8+ to address CVE-2024-4067 #456

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Aug 29, 2024

What is the purpose of this pull request?

To avoid warnings about GHSA-952p-6rrq-rcjv aka CVE-2024-4067

I am a transitive user of fast-glob, so I figured it'd be nice to fix it here.

What changes did you make? (Give an overview)

I pointed to the next patch release as direct dependency.

@olleolleolle olleolleolle changed the title package.json: Refer to micromatch 4.0.8+ package.json: Refer to micromatch 4.0.8+ to address vuln Aug 29, 2024
@olleolleolle olleolleolle changed the title package.json: Refer to micromatch 4.0.8+ to address vuln package.json: Refer to micromatch 4.0.8+ to address CVE-2024-4067 Aug 29, 2024
@biozal
Copy link

biozal commented Oct 2, 2024

Any idea when this will be merged? This causes a lot of npm audit issues.

@zanuka
Copy link

zanuka commented Oct 17, 2024

Would be awesome to get this one merged. Seeing it crop up in tailwindcss 3.4.14 audit, which uses fast-glob 3.3.2

- Regular Expression Denial of Service (ReDoS) in micromatch (Severity: moderate)
  - Affected package: micromatch
  - Patched in: >=4.0.8

@robdefeo
Copy link

robdefeo commented Nov 6, 2024

It would be helpful to get this merged, also having same issue #456 (comment) that @zanuka reported

@mrmlnc mrmlnc merged commit 57c658a into mrmlnc:master Nov 23, 2024
1 check passed
@olleolleolle olleolleolle deleted the patch-1 branch November 24, 2024 08:03
@mrmlnc mrmlnc added this to the 3.3.3 milestone Jan 4, 2025
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Jan 6, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [fast-glob](https://github.com/mrmlnc/fast-glob) | dependencies | patch | [`3.3.2` -> `3.3.3`](https://renovatebot.com/diffs/npm/fast-glob/3.3.2/3.3.3) |

---

### Release Notes

<details>
<summary>mrmlnc/fast-glob (fast-glob)</summary>

### [`v3.3.3`](https://github.com/mrmlnc/fast-glob/releases/tag/3.3.3)

[Compare Source](mrmlnc/fast-glob@3.3.2...3.3.3)

> **Full Changelog**: mrmlnc/fast-glob@3.3.2...3.3.3

#### 💬 Common

-   Refer to micromatch@4.0.8 to avoid annoying npm audit spam ([#&#8203;443](mrmlnc/fast-glob#443), [#&#8203;444](mrmlnc/fast-glob#444), [#&#8203;454](mrmlnc/fast-glob#454), [#&#8203;456](mrmlnc/fast-glob#456), [#&#8203;457](mrmlnc/fast-glob#457), [#&#8203;461](mrmlnc/fast-glob#461))

#### 🐛 Bug fixes

-   Apply absolute negative patterns to full path instead of file path ([#&#8203;441](mrmlnc/fast-glob#441), thanks [@&#8203;webpro](https://github.com/webpro))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "* 0-3 * * *" (UTC), Automerge - "* 0-3 * * *" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45MC4wIiwidXBkYXRlZEluVmVyIjoiMzkuOTAuMCIsInRhcmdldEJyYW5jaCI6ImZvcmdlam8iLCJsYWJlbHMiOlsiZGVwZW5kZW5jeS11cGdyYWRlIiwidGVzdC9ub3QtbmVlZGVkIl19-->

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6476
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Co-authored-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Co-committed-by: Renovate Bot <forgejo-renovate-action@forgejo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants