Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Basic Edge support #9

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[WIP] Basic Edge support #9

wants to merge 11 commits into from

Conversation

mrmr1993
Copy link
Owner

@mrmr1993 mrmr1993 commented Nov 15, 2017

Currently, this gives basic support to Edge (issue philc#2076). Most of the changes are fairly unobjectionable, 961863e and 30a36d6 being the notable exceptions.

Things that I've tested and found not working:

  • Visual modes, due to no support for the non-standard Selection.modify that we use.
  • focusInput, where Edge rejects the XPath that we use to get the input elements
  • simulated clicks hit the pop-up blocker (as in Firefox, so we can use the same workaround), so some link hint commands don't work
  • clipboard commands (esp. copy) are unreliable
  • all commands/UI using UIComponent -- the HUD, Vomnibar and the help dialog -- are broken
  • exclusions pop-up is partly concealed by a scrollbar (at least, in my Window VM)

Edit (2017-11-15):

  • UIComponent frames don't get focused when activated
  • multi-frame link hints don't work properly/reliably
  • find mode doesn't work
  • Vomnibar doesn't seem to get suggestions from history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant