Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Basic Edge support #9

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[WIP] Basic Edge support #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
961863e
Add Edge stubs for Chrome APIs
mrmr1993 Nov 14, 2017
089a3b1
Edge: Add persistent key for the background page
mrmr1993 Nov 14, 2017
a508e01
Edge: Add author field to manifest
mrmr1993 Nov 14, 2017
87d304e
Edge: Move manifest comment out of content_scripts to avoid error
mrmr1993 Nov 14, 2017
93db67d
Add Utils.isChrome method
mrmr1993 Nov 15, 2017
34b11df
Use browserAction.setIcon with path for non-chrome browsers
mrmr1993 Nov 15, 2017
30a36d6
Edge: Accept Esc for Escape and Del for Delete in KeyboardUtils
mrmr1993 Nov 15, 2017
7c915c3
Edge: Accept own window as a message source for UIComponentServer
mrmr1993 Nov 15, 2017
5711776
Edge: Disable most logging and fix getBackgroundPage error in polyfill
mrmr1993 Nov 15, 2017
a26d293
Edge: Disable most background page logging from polyfills
mrmr1993 Nov 15, 2017
df1b8b6
Edge: Circumvent the popup blocker for all non-Chrome browsers
mrmr1993 Nov 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions background_scripts/main.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,15 +324,18 @@ Frames =
enabledState = Exclusions.isEnabledForUrl request.url

if request.frameIsFocused
chrome.browserAction.setIcon? tabId: tabId, imageData: do ->
enabledStateIcon =
if not enabledState.isEnabledForUrl
DISABLED_ICON
else if 0 < enabledState.passKeys.length
PARTIAL_ICON
else
ENABLED_ICON
iconImageData[enabledStateIcon]
enabledStateIcon =
if not enabledState.isEnabledForUrl
DISABLED_ICON
else if 0 < enabledState.passKeys.length
PARTIAL_ICON
else
ENABLED_ICON
if Utils.isChrome()
iconInfo = tabId: tabId, imageData: iconImageData[enabledStateIcon]
else
iconInfo = tabId: tabId, path: enabledStateIcon
chrome.browserAction.setIcon? iconInfo

port.postMessage extend request, enabledState

Expand Down
2 changes: 1 addition & 1 deletion lib/dom_utils.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ DomUtils =
eventSequence = ["mouseover", "mousedown", "mouseup", "click"]
for event in eventSequence
defaultActionShouldTrigger = @simulateMouseEvent event, element, modifiers
if event == "click" and defaultActionShouldTrigger and Utils.isFirefox()
if event == "click" and defaultActionShouldTrigger and not Utils.isChrome()
# Firefox doesn't (currently) trigger the default action for modified keys.
DomUtils.simulateClickDefaultAction element, modifiers
defaultActionShouldTrigger # return the values returned by each @simulateMouseEvent call.
Expand Down
Loading