fix: check for localStorage support only once #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe if you run |
Released: v1.1.1 🎉This has been released in v1.1.1! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Ninemillimetermel
suggested changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31
This moves the check for localStorage support from each hydrate / persist call to instead happen only once when the module is imported.
Note: It might be nice to add a
Contributing.mdor a note in the readme about formatting of commit messages, since there's a pre-commit lint set up. LMK if I didn't pick the right option (I'm not so familiar with those conventions).