Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for localStorage support only once #32

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fix: check for localStorage support only once #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ function supportsLocalStorage() {
}
}

const hasLocalStorageSupport = supportsLocalStorage()

/**
* Checks that accessing a given property on an object
* by name does not throw an error.
Expand Down Expand Up @@ -168,7 +170,7 @@ class CookieStore {
* Hydrates the virtual cookie store from the `localStorage` if defined.
*/
hydrate(): void {
if (!supportsLocalStorage()) {
if (!hasLocalStorageSupport) {
return
}

Expand Down Expand Up @@ -215,7 +217,7 @@ Invalid value has been removed from localStorage to prevent subsequent failed pa
* so they are available on the next page load.
*/
persist(): void {
if (!supportsLocalStorage()) {
if (!hasLocalStorageSupport) {
return
}

Expand Down
Loading