Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calcmysky: New package #18697

Closed
wants to merge 6 commits into from
Closed

Conversation

hmartinez82
Copy link
Contributor

@hmartinez82 hmartinez82 commented Oct 3, 2023

$ ctest
Test project C:/M_P/mingw-w64-calcmysky/src/build-CLANGARM64
      Start  1: Spectrum test 1
 1/12 Test  #1: Spectrum test 1 .....................................................   Passed    0.05 sec
      Start  2: Spectrum test 2
 2/12 Test  #2: Spectrum test 2 .....................................................   Passed    0.01 sec
      Start  3: Spectrum test 3
 3/12 Test  #3: Spectrum test 3 .....................................................   Passed    0.02 sec
      Start  4: Spectrum test 4
 4/12 Test  #4: Spectrum test 4 .....................................................   Passed    0.02 sec
      Start  5: Fourier interpolation,  odd-length input, identity transformation
 5/12 Test  #5: Fourier interpolation,  odd-length input, identity transformation ...   Passed    0.04 sec
      Start  6: Fourier interpolation, even-length input, identity transformation
 6/12 Test  #6: Fourier interpolation, even-length input, identity transformation ...   Passed    0.01 sec
      Start  7: Fourier interpolation,  odd-length input, integral upsampling
 7/12 Test  #7: Fourier interpolation,  odd-length input, integral upsampling .......   Passed    0.01 sec
      Start  8: Fourier interpolation, even-length input, integral upsampling
 8/12 Test  #8: Fourier interpolation, even-length input, integral upsampling .......   Passed    0.01 sec
      Start  9: Fourier interpolation,  odd-length input, fractional upsampling
 9/12 Test  #9: Fourier interpolation,  odd-length input, fractional upsampling .....   Passed    0.01 sec
      Start 10: Fourier interpolation, even-length input, fractional upsampling
10/12 Test #10: Fourier interpolation, even-length input, fractional upsampling .....   Passed    0.01 sec
      Start 11: Spline interpolation
11/12 Test #11: Spline interpolation ................................................   Passed    0.04 sec
      Start 12: Catching exceptions from libShowMySky
12/12 Test #12: Catching exceptions from libShowMySky ...............................   Passed    0.10 sec

100% tests passed, 0 tests failed out of 12

Total Test time (real) =   0.34 sec

@hmartinez82 hmartinez82 marked this pull request as draft October 3, 2023 08:12
@hmartinez82 hmartinez82 marked this pull request as ready for review October 3, 2023 08:25
@hmartinez82 hmartinez82 changed the title [new-package] calcmysky: Add mingw64 and ucrt64 builds [new-package] calcmysky: Add mingw64. ucrt64 clang64 and clangarm64 builds Oct 3, 2023
@hmartinez82 hmartinez82 changed the title [new-package] calcmysky: Add mingw64. ucrt64 clang64 and clangarm64 builds [new-package] calcmysky: Add mingw64. ucrt64, clang64 and clangarm64 builds Oct 3, 2023
@Biswa96
Copy link
Member

Biswa96 commented Oct 3, 2023

It is not required to add qt6 suffix. There is no qt5 version of this package. Also it is not required to add msystem names in commit message.

@hmartinez82 hmartinez82 changed the title [new-package] calcmysky: Add mingw64. ucrt64, clang64 and clangarm64 builds calcmysky: New package Oct 3, 2023
@Biswa96 Biswa96 added the new-package Pull request which adds new package(s) label Oct 3, 2023
* This is the name that should be passed to dlopen-like functions. Use this macro for portability instead of hard-coding a string.
*/
-#define SHOWMYSKY_LIB_NAME (QT_VERSION_MAJOR==5 ? "ShowMySky-Qt5" : "ShowMySky-Qt6")
+#define SHOWMYSKY_LIB_NAME (QT_VERSION_MAJOR==5 ? "libShowMySky-Qt5" : "libShowMySky-Qt6")
Copy link
Member

@Biswa96 Biswa96 Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for DLL name? DLL name can be without 'lib' prefix but import library name should have 'lib' prefix.

Copy link
Contributor Author

@hmartinez82 hmartinez82 Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for the DLL. But the DLL was created with the lib prefix. :( . I don't know why it was created with that prefix. I'll take a look again if I can find what is adding the prefix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects add the following line for mingw only to prevent DLLs with 'lib' prefix.

SET_TARGET_PROPERTIES(target_name PROPERTIES PREFIX "")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! I'll look into that!

pkgname="${MINGW_PACKAGE_PREFIX}-${_realname}"
pkgver=0.3.1
pkgrel=1
pkgdesc="Planetary atmosphere light scattering simulator"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pkgdesc="Planetary atmosphere light scattering simulator"
pkgdesc="Planetary atmosphere light scattering simulator (mingw-w64)"

@hmartinez82 hmartinez82 closed this Oct 5, 2023
@hmartinez82 hmartinez82 deleted the calcmysky branch October 10, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-package Pull request which adds new package(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants