-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calcmysky: New package #18697
calcmysky: New package #18697
Conversation
hmartinez82
commented
Oct 3, 2023
•
edited
Loading
edited
It is not required to add qt6 suffix. There is no qt5 version of this package. Also it is not required to add msystem names in commit message. |
* This is the name that should be passed to dlopen-like functions. Use this macro for portability instead of hard-coding a string. | ||
*/ | ||
-#define SHOWMYSKY_LIB_NAME (QT_VERSION_MAJOR==5 ? "ShowMySky-Qt5" : "ShowMySky-Qt6") | ||
+#define SHOWMYSKY_LIB_NAME (QT_VERSION_MAJOR==5 ? "libShowMySky-Qt5" : "libShowMySky-Qt6") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for DLL name? DLL name can be without 'lib' prefix but import library name should have 'lib' prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for the DLL. But the DLL was created with the lib
prefix. :( . I don't know why it was created with that prefix. I'll take a look again if I can find what is adding the prefix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some projects add the following line for mingw only to prevent DLLs with 'lib' prefix.
SET_TARGET_PROPERTIES(target_name PROPERTIES PREFIX "")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! I'll look into that!
pkgname="${MINGW_PACKAGE_PREFIX}-${_realname}" | ||
pkgver=0.3.1 | ||
pkgrel=1 | ||
pkgdesc="Planetary atmosphere light scattering simulator" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkgdesc="Planetary atmosphere light scattering simulator" | |
pkgdesc="Planetary atmosphere light scattering simulator (mingw-w64)" |