-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pause button #163
Add pause button #163
Conversation
@mthenw Please see this PR |
@mthenw ping |
Hey, I'm sorry about super late answer. What I actually see in this PR is a "ignore new lines" functionality. Could you elaborate more about what's the use case and are there any reported issues that this PR solves? |
We use 'frontail' in our development infrastructure and it generating a large stream of logs. But first, it is difficult to keep some of the logs in view when adding and deleting new lines in the browser. |
As a frequent frontail user I'm in support of this functionality, but I'd like to see it tell you how many new log lines you've missed since it's been paused. and leave that in the list when it's unpaused so it's clear that there is a gap in the data you're seeing. |
@RickeyWard I will try to add a line with a counter. |
@mthenw What prevents you from accepting my contribution? |
@levonet sorry for being so terrible at answering. I'm basically not sure if this is the type of functionality that I want to include in frontail. I don't have any strong arguments, tho :( Let's do this. I'm testing this functionality right now and will give you some feedback shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great. Just a few comments.
In the current implementation favicon badge updates as if there're new lines. But when the streaming is paused we shouldn't probably update it. Can you fix that?
@levonet let me know if you are still willing to contribute (you already did a lot and I totally get it if you're no longer interested). If not I will fix those few issues by myself. |
This problem occurs when the filter input loses focus. |
@mthenw done |
@levonet thank you for your contribution and sorry that it took so long. |
Related to mthenw#163
resolve #137