Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pause button #163

Merged
merged 6 commits into from
Aug 27, 2019
Merged

Add pause button #163

merged 6 commits into from
Aug 27, 2019

Conversation

levonet
Copy link
Contributor

@levonet levonet commented Apr 4, 2019

resolve #137
Знімок екрана 2019-04-11 о 15 23 42Знімок екрана 2019-04-11 о 15 23 49
Знімок екрана 2019-04-11 о 15 22 57Знімок екрана 2019-04-11 о 15 23 20
photo_2019-04-11 15 18 10

@levonet
Copy link
Contributor Author

levonet commented Apr 11, 2019

@mthenw Please see this PR

@levonet
Copy link
Contributor Author

levonet commented Apr 19, 2019

@mthenw ping

@mthenw
Copy link
Owner

mthenw commented May 4, 2019

Hey, I'm sorry about super late answer. What I actually see in this PR is a "ignore new lines" functionality. Could you elaborate more about what's the use case and are there any reported issues that this PR solves?

@levonet
Copy link
Contributor Author

levonet commented May 4, 2019

We use 'frontail' in our development infrastructure and it generating a large stream of logs.
To separate the necessary we use filters.

But first, it is difficult to keep some of the logs in view when adding and deleting new lines in the browser.
Second, the new data quickly displaces the necessary data from the buffer. We can't endlessly increase the number of rows that are stored in the browser.
Third, there is often a situation when you need to quickly stop the log in order not to search for the necessary information for a long time.
The 'pause' button solves these three problems.

@RickeyWard
Copy link

As a frequent frontail user I'm in support of this functionality, but I'd like to see it tell you how many new log lines you've missed since it's been paused. and leave that in the list when it's unpaused so it's clear that there is a gap in the data you're seeing.

@levonet
Copy link
Contributor Author

levonet commented May 8, 2019

@RickeyWard I will try to add a line with a counter.
Line like ==> SKIPED: 999 <==.

@levonet
Copy link
Contributor Author

levonet commented Aug 26, 2019

@mthenw What prevents you from accepting my contribution?

@mthenw
Copy link
Owner

mthenw commented Aug 26, 2019

@levonet sorry for being so terrible at answering. I'm basically not sure if this is the type of functionality that I want to include in frontail. I don't have any strong arguments, tho :(

Let's do this. I'm testing this functionality right now and will give you some feedback shortly.

Copy link
Owner

@mthenw mthenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great. Just a few comments.

In the current implementation favicon badge updates as if there're new lines. But when the streaming is paused we shouldn't probably update it. Can you fix that?

web/assets/app.js Outdated Show resolved Hide resolved
test/app.js Outdated Show resolved Hide resolved
web/assets/styles/dark.css Outdated Show resolved Hide resolved
@mthenw
Copy link
Owner

mthenw commented Aug 26, 2019

@levonet let me know if you are still willing to contribute (you already did a lot and I totally get it if you're no longer interested).

If not I will fix those few issues by myself.

@levonet
Copy link
Contributor Author

levonet commented Aug 26, 2019

In the current implementation favicon badge updates as if there're new lines. But when the streaming is paused we shouldn't probably update it. Can you fix that?

This problem occurs when the filter input loses focus.
Apparently, this problem was before my changes. I'll try to fix it.

@levonet
Copy link
Contributor Author

levonet commented Aug 26, 2019

@mthenw done

@mthenw mthenw merged commit 01afdc8 into mthenw:master Aug 27, 2019
@mthenw
Copy link
Owner

mthenw commented Aug 27, 2019

@levonet thank you for your contribution and sorry that it took so long.

EvertEt added a commit to EvertEt/frontail that referenced this pull request Feb 25, 2021
@EvertEt EvertEt mentioned this pull request Feb 25, 2021
mthenw pushed a commit that referenced this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add button to stop/restart watch
3 participants