Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

build und upload to ghcr via github action #37

Closed
wants to merge 2 commits into from

Conversation

b3n4kh
Copy link
Contributor

@b3n4kh b3n4kh commented Jan 22, 2023

Build Container image and upload to GitHub Container Registry via GitHub Action.

Runs on push or merge to master.

See https://github.com/b3n4kh/mailwhale/actions/runs/3980644873/jobs/6823874626 for example run.
See https://github.com/b3n4kh/mailwhale/pkgs/container/mailwhale for example package.

* bump build image versions
* add github action
@muety
Copy link
Owner

muety commented Jan 22, 2023

Awesome contribution, thanks a lot! 🙏 I'd only like to ask you for two small changes:

  • Could you please make this only run when a Git tag is created, instead of for every push to master? Please also tag the image with that Git tag then.
  • Could you please also adapt the "Run with Docker" section of the README to include the official image, instead of a self-built one?

Closes #28.

@b3n4kh
Copy link
Contributor Author

b3n4kh commented Jan 22, 2023

Updated to run on tag.

Updated Readme - just noticed markdownlint fixed some styling, can be reversed if needed.

See: https://github.com/b3n4kh/mailwhale/actions/runs/3981386849 for example run.

@b3n4kh b3n4kh force-pushed the feature/github_action branch from 7934907 to 5d4d574 Compare January 22, 2023 20:33
@b3n4kh b3n4kh mentioned this pull request Jan 22, 2023
@b3n4kh
Copy link
Contributor Author

b3n4kh commented Jan 22, 2023

This PR might be obsoleted by: #39

@muety muety closed this Jan 23, 2023
@b3n4kh b3n4kh deleted the feature/github_action branch January 23, 2023 08:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants