Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Feature/goreleaser #39

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Feature/goreleaser #39

merged 3 commits into from
Jan 24, 2023

Conversation

b3n4kh
Copy link
Contributor

@b3n4kh b3n4kh commented Jan 22, 2023

Fixes: #38

Adds support for goreleaser to build binary releases and docker images.

See: https://github.com/b3n4kh/mailwhale/releases/tag/v1.0.0 for example release

This might obsolete: #37

build and upload to GHCR via GitHub Action

* bump build image versions
* add github action

build on tag & update README
@b3n4kh b3n4kh force-pushed the feature/goreleaser branch from 77cc8f4 to 1dad991 Compare January 22, 2023 22:52
@muety
Copy link
Owner

muety commented Jan 23, 2023

Pretty cool stuff, thank you! Only added two more minor change requests, if you don't mind.

Closes #28.

@muety
Copy link
Owner

muety commented Jan 23, 2023

Oh sorry, one more thing to add. This would actually be quite important for me. Would it be possible to set the title / name of the release to whatever the corresponding Git tag was? So v<tag-here> or sth.

@b3n4kh
Copy link
Contributor Author

b3n4kh commented Jan 23, 2023

That is the default behavior:

From the goreleaser docs

  # You can change the name of the release.
  # Default is `{{.Tag}}` on OSS and `{{.PrefixedTag}}` on Pro.
  name_template: "{{.ProjectName}}-v{{.Version}} {{.Env.USER}}"

So default is the Tag, but it can be adjusted.

There is also a "header" and "footer" to the release, with a custom text (additionally to the autogenerated changelog)

@muety
Copy link
Owner

muety commented Jan 23, 2023

Never mind then! I was just confused by your release being named 1.0.0, while the current version is 0.13.2, but I see you created a 1.0.0 tag, so all good 👍

@b3n4kh
Copy link
Contributor Author

b3n4kh commented Jan 23, 2023

Yeah, I should have checked version.txt - might be worth considering adding a check in the pipeline to ensure the tag matches the current version.txt.

Offtopic: I personally liked setting the version during build via ldflags - could be discussed in an issue, that would remove the need for the version.txt file during runtime.

.goreleaser.yaml Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
@muety muety merged commit dc15c5b into muety:master Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

releases via goreleaser
2 participants