Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Migrate content to the new location #30757

Merged
merged 41 commits into from
Feb 4, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 24, 2022

Ahrefs result: https://app.ahrefs.com/site-audit/3276941/5/overview

Current URL: https://deploy-preview-30757--material-ui.netlify.app/components/buttons/
New URL: https://deploy-preview-30757--material-ui.netlify.app/material/react-button/

Once this PR is merged, there might be some conflict on other PRs if they touch .md file. Those PRs have to revert the change and update the markdown in /docs/data/*.md instead.


@mui-bot
Copy link

mui-bot commented Jan 24, 2022

No bundle size changes

Generated by 🚫 dangerJS against 021a22c

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 24, 2022
This was referenced Feb 4, 2022
@Nef10 Nef10 mentioned this pull request Feb 4, 2022
2 tasks
@siriwatknp siriwatknp mentioned this pull request Feb 4, 2022
32 tasks
@oliviertassinari
Copy link
Member

A side note, I'm not a fan of this change:

-{{"demo": "pages/components/alert/TransitionAlerts.js"}}
+{{"demo": "TransitionAlerts.js"}}

Previously, you could grep the demo and search it in your IDE, zero conflicts. Now, there is a higher chance that the name will conflict with another folder.

@siriwatknp
Copy link
Member Author

A side note, I'm not a fan of this change:

-{{"demo": "pages/components/alert/TransitionAlerts.js"}}
+{{"demo": "TransitionAlerts.js"}}

Previously, you could grep the demo and search it in your IDE, zero conflicts. Now, there is a higher chance that the name will conflict with another folder.

Let me state why I did this change:

  1. there is a TODO in loader.js
     // TODO: const moduleID = demoName;
     // The import paths currently use a completely different format.
     // They should just use relative imports.
    
  2. Using relative imports means no couple with path (the whole folder can be moved around with no change, I know that this is a very rare case but I like having things independent from each other.

Can you explain more about what did you usually search for? Maybe we can do something about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants