Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DatePicker] Fix auto scroll to selected year in year picker view #30423

Closed

Conversation

boutahlilsoufiane
Copy link
Contributor

@boutahlilsoufiane boutahlilsoufiane commented Dec 27, 2021

Fix mui/mui-x#4642.

The PR contains the fix of not scrolling to the selected year in the year picker view.

@boutahlilsoufiane boutahlilsoufiane changed the title [DatePicker] Fix not auto scroll to selected year when toggled to year view [DatePicker] Fix auto scroll to selected year when toggled to year picker view Dec 27, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Dec 27, 2021

Details of bundle changes

Generated by 🚫 dangerJS against 1850bb1

@boutahlilsoufiane boutahlilsoufiane changed the title [DatePicker] Fix auto scroll to selected year when toggled to year picker view [DatePicker] Fix auto scroll to selected year in picker view Dec 27, 2021
@boutahlilsoufiane boutahlilsoufiane changed the title [DatePicker] Fix auto scroll to selected year in picker view [DatePicker] Fix auto scroll to selected year in year picker view Dec 27, 2021
@danilo-leal danilo-leal added the component: date picker This is the name of the generic UI component, not the React module! label Feb 1, 2022
@siriwatknp
Copy link
Member

👋 The migration PR has been merged.

Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)

  1. pull latest master from upstream to your branch
  2. if your PR has changes on the *.md or demo files, you are likely to encounter conflict because all of them have been moved to the new folder.
    2.1 revert the change on those markdown files you did
    2.2 pull latest master from upstream (you should not see conflict)
    2.3 make the changes again at docs/data/material/*
  3. run yarn docs:api
    • you might see the changes in docs/pages/material/api/* if your PR touches some of the components
    • it is okay if there is no changes

If you are struggle with the steps above, feel free to tag @siriwatknp

@mui-bot
Copy link

mui-bot commented Feb 16, 2022

Details of bundle changes

Generated by 🚫 dangerJS against a3c1f6f

@boutahlilsoufiane
Copy link
Contributor Author

Hi @siriwatknp, thanks a lot for your instructions, I followed them but after that, the check test_types has failed, I tried to solve the issue but I didn’t succeed, now I’m stuck, could you please give me a hint in order to solve the issue?

@rwieruch
Copy link

Looking forward to this fix! Thanks @boutahlilsoufiane for putting the effort into it 🚀

@mnajdova
Copy link
Member

@boutahlilsoufiane note that the pickers are moving inside https://github.com/mui/mui-x. I would propose opening a PR there once they are established. Adding a test case for it would be nice too, to make sure that this does not break other scenarios. cc @flaviendelangle

@rwieruch you can add the autoFocus prop on the StaticDatePicker directly in the mean time.

@mnajdova mnajdova closed this Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: date picker This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DatePicker] StaticDatePicker does not auto scroll to selected year when toggled to year view
7 participants