Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix icon linking implementation concurrent safe #30428

Merged
merged 5 commits into from
Mar 1, 2022
Merged

[docs] Fix icon linking implementation concurrent safe #30428

merged 5 commits into from
Mar 1, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Dec 28, 2021

I was probably wrong with my previous assessment of concurrent mode compatibility of this hook. Let's play safe and only update refs in effects.

@mui-pr-bot
Copy link

mui-pr-bot commented Dec 28, 2021 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 410446f

@Janpot Janpot changed the title [fix] Make previous icon linking concurrent safe [fix] Make previous icon linking implementation concurrent safe Dec 28, 2021
@oliviertassinari oliviertassinari changed the title [fix] Make previous icon linking implementation concurrent safe [docs] Fix icon linking implementation concurrent safe Dec 29, 2021
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Dec 29, 2021
@siriwatknp siriwatknp added the PR: needs test The pull request can't be merged label Jan 5, 2022
@siriwatknp
Copy link
Member

Will try to add a test for this.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2022
@siriwatknp
Copy link
Member

👋 The migration PR has been merged.

Please follow these steps to make sure that the contents are all updated. (Sorry for the inconvenience)

  1. pull latest master from upstream to your branch
  2. if your PR has changes on the *.md or demo files, you are likely to encounter conflict because all of them have been moved to the new folder.
    2.1 revert the change on those markdown files you did
    2.2 pull latest master from upstream (you should not see conflict)
    2.3 make the changes again at docs/data/material/*
  3. run yarn docs:api
    • you might see the changes in docs/pages/material/api/* if your PR touches some of the components
    • it is okay if there is no changes

If you are struggle with the steps above, feel free to tag @siriwatknp

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2022
@mui-bot
Copy link

mui-bot commented Feb 4, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 7a2bfab

siriwatknp
siriwatknp approved these changes Mar 1, 2022
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 e2e test added to make sure that the popup shows the icon

@siriwatknp siriwatknp removed the PR: needs test The pull request can't be merged label Mar 1, 2022
@siriwatknp siriwatknp merged commit 2a81d58 into mui:master Mar 1, 2022
@Janpot Janpot deleted the concurrent branch March 1, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Janpot @mui-pr-bot @siriwatknp @mui-bot @oliviertassinari