Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextField] Labels aren't floating on first SSR render #6425

Closed
kybarg opened this issue Mar 23, 2017 · 0 comments · Fixed by #6566
Closed

[TextField] Labels aren't floating on first SSR render #6425

kybarg opened this issue Mar 23, 2017 · 0 comments · Fixed by #6566
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!

Comments

@kybarg
Copy link
Contributor

kybarg commented Mar 23, 2017 •
edited
Loading

Problem description

When rendering on server labels aren't floating. They float only when client side scripts are executed.

image

Update 1

This is not related to server rendering. I think need to detect if field is dirty in FormControl before rendering.

Versions

  • Material-UI: next
@mbrookes mbrookes changed the title [TextFiled] Labels aren't floating when rendering on server. [TextField] Labels aren't floating when rendering on server. Mar 23, 2017
@mbrookes mbrookes added the component: text field This is the name of the generic UI component, not the React module! label Mar 23, 2017
@kybarg kybarg changed the title [TextField] Labels aren't floating when rendering on server. [TextField] Labels aren't floating on first render Apr 10, 2017
kybarg added a commit to kybarg/material-ui that referenced this issue Apr 10, 2017
@kybarg
Adjusted styles accordingto specs, fixed mui#6425
7f966d0
@kybarg kybarg mentioned this issue Apr 10, 2017
Merged
6 tasks
@rosskevin rosskevin changed the title [TextField] Labels aren't floating on first render [TextField] Labels aren't floating on first SSR render May 4, 2017
@oliviertassinari oliviertassinari added next bug 🐛 Something doesn't work labels May 21, 2017
oliviertassinari pushed a commit that referenced this issue May 30, 2017
@kybarg @oliviertassinari
[TextField] Make it meet the guidelines (#6566)
1c96695 
* Adjusted styles accordingto specs, fixed #6425

* Fixes, simplified styles

* Removed dead `TextFieldLabel` component as for #6580

* Added colors according to specs, `InputLabel` disabled prop

* Avoiding label flicker and blurry text in webkit browsers

* More smooth label animation.

* More smooth font-size animation

* Proper error color, added `FormHelperText` component

* FormHelperText docs

* Fixed lint errors

* Added new component to styles order, fixes

* Fixed disabled border style

* FormHelperText exports

* Remove unused TextFieldLabel

* Form helper fixes, test, docs

* TextField tests for FormHelperText

* Get rid of TextFieldLabel.md, added tests for InputLabel

* Added tests for FormControl

* Make dirty if `defaultValue` is set

* Fix helper text font

* Fix label "flicker" in webkit browsers.

* Use `theme.spacing.unit` instead of number values

* Disabled composed text field demo

* Fixed type check

* Fixed type check error

* Make `ComposedTextFiled` accept disabled prop

* Fixed lint

* Fixed docs and input

* Exposed FormHelperTextProps and InputLabelProps

* Fixed docs

* Fixed multiline styles

* Placeholder + Label behaviour

* Fixes

Placeholder styles look ugly. laceholder prefixing is to be impplemented
in next JSS versions.

* Fixed lint errors

* Typo fixes

* Typo fixes 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TextField] Make it meet guidelines kybarg/material-ui
3 participants
@mbrookes @oliviertassinari @kybarg