Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextFieldLabel] Is there need for this component #6580

Closed
kybarg opened this issue Apr 11, 2017 · 5 comments · Fixed by #6566
Closed

[TextFieldLabel] Is there need for this component #6580

kybarg opened this issue Apr 11, 2017 · 5 comments · Fixed by #6566
Labels
component: text field This is the name of the generic UI component, not the React module!

Comments

@kybarg
Copy link
Contributor

kybarg commented Apr 11, 2017 •
edited
Loading

Noticed there is TextFieldLabel component while this is almost copy of InputLabel and TextField component depends on InputLabel, not TextFieldLabel.

  • Material-UI: next
@mbrookes
Copy link
Member

@kybarg Also noticed that recently, and promptly forgot to go back and investigate!

Looks like it's dead code: 8e2714b

@kybarg
Copy link
Contributor Author

kybarg commented Apr 11, 2017

@mbrookes Should i make a PR?

@mbrookes
Copy link
Member

@kybarg I think you might as well just kill it in your current PR. Don't forget to update the components list at the top of: https://github.com/callemall/material-ui/blob/next/docs/src/pages/component-demos/text-fields/text-fields.md

@kybarg
Copy link
Contributor Author

kybarg commented Apr 11, 2017

@mbrookes ok, thank you for the fast reply

kybarg added a commit to kybarg/material-ui that referenced this issue Apr 11, 2017
@kybarg
Removed dead TextFieldLabel component as for mui#6580
b5fb82a
@kybarg kybarg closed this as completed Apr 11, 2017
@kybarg kybarg mentioned this issue Apr 12, 2017
Merged
6 tasks
@mbrookes
Copy link
Member

@kybarg, let's keep this open for now until your PR is merged. Please add it to the description there so it auto closes.

@mbrookes mbrookes reopened this Apr 12, 2017
oliviertassinari pushed a commit that referenced this issue May 30, 2017
@kybarg @oliviertassinari
[TextField] Make it meet the guidelines (#6566)
1c96695 
* Adjusted styles accordingto specs, fixed #6425

* Fixes, simplified styles

* Removed dead `TextFieldLabel` component as for #6580

* Added colors according to specs, `InputLabel` disabled prop

* Avoiding label flicker and blurry text in webkit browsers

* More smooth label animation.

* More smooth font-size animation

* Proper error color, added `FormHelperText` component

* FormHelperText docs

* Fixed lint errors

* Added new component to styles order, fixes

* Fixed disabled border style

* FormHelperText exports

* Remove unused TextFieldLabel

* Form helper fixes, test, docs

* TextField tests for FormHelperText

* Get rid of TextFieldLabel.md, added tests for InputLabel

* Added tests for FormControl

* Make dirty if `defaultValue` is set

* Fix helper text font

* Fix label "flicker" in webkit browsers.

* Use `theme.spacing.unit` instead of number values

* Disabled composed text field demo

* Fixed type check

* Fixed type check error

* Make `ComposedTextFiled` accept disabled prop

* Fixed lint

* Fixed docs and input

* Exposed FormHelperTextProps and InputLabelProps

* Fixed docs

* Fixed multiline styles

* Placeholder + Label behaviour

* Fixes

Placeholder styles look ugly. laceholder prefixing is to be impplemented
in next JSS versions.

* Fixed lint errors

* Typo fixes

* Typo fixes 2
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager added component: text field This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: text field This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TextField] Make it meet guidelines kybarg/material-ui
4 participants
@mbrookes @oliviertassinari @kybarg @zannager