Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ExpansionPanel] Rename to Accordion, add warning to current exports #21560

Merged
merged 24 commits into from
Jun 29, 2020
Merged

[ExpansionPanel] Rename to Accordion, add warning to current exports #21560

merged 24 commits into from
Jun 29, 2020

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Jun 24, 2020 •
edited by oliviertassinari
Loading

Deprecation

The ExpansionPanel components were renamed to Accordion. The old imports will be removed in v5.

-import { ExpansionPanel } from '@material-ui/core';
+import { Accordion } from '@material-ui/core';

This PR cherry picks changes from #21494 to be merged in master.

Also cover #21630

### Question
Should we revert the changes in the examples and docs API pages?

mnajdova and others added 2 commits June 24, 2020 19:47
@mnajdova @oliviertassinari @eps1lon
[ExpansionPanel] Rename to Accordion (mui#21494)
109e334 
* wip

* wip

* reverted some changes

* sorting

* migration

* fix in migration

* fix in migration

* fix in migration

* Update docs/src/pages/getting-started/supported-components/supported-components.md

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* added redirect

* fixed material design links

* codemod fix

* prettier + formatted

* changed accordions to accordion

* docs:api

* renamed accordions to accordion

* Update docs/src/pages/components/accordion/accordion.md

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* Update docs/src/pages/components/accordion/accordion.md

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* Update docs/src/pages/components/accordion/accordion.md

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* added deprecated exports for ExpansionPanel components

* added motivation for renaming component

* Update docs/src/pages/components/accordion/accordion.md

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* Update docs/src/pages/guides/migration-v4/migration-v4.md

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* Update docs/src/pages/guides/migration-v4/migration-v4.md

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>

* cleandup migration

* prettier

* changed comments on deprecated components

* removed

* reverted del files

* renamed

* fixed d.ts fiels

* r

* added

* renamed

* renamed types

* redirects

* Revert markdown source changes

* Move markdown source from expansion-panel to accordion

* Expansion Panel -> Accordion

* Revert attempt at renaming

Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Sebastian Silbermann <silbermann.sebastian@gmail.com>
@mnajdova
docs:api
135bd37
@oliviertassinari oliviertassinari added the deprecation New deprecation message label Jun 24, 2020
@oliviertassinari oliviertassinari changed the title Feat/expansion panel to accordion [ExpensionPanel] Make it deprecated, imports should be updated Jun 24, 2020
@oliviertassinari
Copy link
Member

Should we revert the changes in the examples and docs API pages?

I don't think so, I think that we should apply the very same changes. We rename the component in v4, we make the imports to ExpensionPanel deprecated. In v5, these imports break.

@mui-pr-bot
Copy link

mui-pr-bot commented Jun 24, 2020 •
edited
Loading

@material-ui/core: parsed: +1.42% , gzip: +0.27%

Details of bundle changes.

Comparing: 9e7c0c1...39b2241

Details of page changes
bundle Size Change Size Gzip Change Gzip
/components/accordion ▲ +21.4 kB (+Infinity% ) 21.4 kB ▼ -1 B (-Infinity% ) -1 B
/components/expansion-panels ▼ -20.8 kB (-100.00% ) 0 B ▲ +1 B (-100.00% ) 0 B
/api-docs/accordion ▲ +1.97 kB (+Infinity% ) 1.97 kB ▼ -1 B (-Infinity% ) -1 B
/api-docs/accordion-summary ▲ +1.7 kB (+Infinity% ) 1.7 kB ▼ -1 B (-Infinity% ) -1 B
/api-docs/accordion-actions ▲ +1.48 kB (+Infinity% ) 1.48 kB ▼ -1 B (-Infinity% ) -1 B
/api-docs/accordion-details ▲ +1.4 kB (+Infinity% ) 1.4 kB ▼ -1 B (-Infinity% ) -1 B
/api-docs/expansion-panel-summary ▲ +120 B (+6.98% ) 1.84 kB -- -1 B
/api-docs/expansion-panel-actions ▲ +60 B (+4.03% ) 1.55 kB -- -1 B
/api-docs/expansion-panel-details ▲ +60 B (+4.26% ) 1.47 kB -- -1 B
/api-docs/expansion-panel ▲ +60 B (+3.03% ) 2.04 kB -- -1 B
/getting-started/supported-components ▲ +20 B (+0.30% ) 6.76 kB -- -1 B
/api-docs/grid-list-tile ▲ +10 B (+0.58% ) 1.73 kB -- -1 B
/api-docs/input-adornment ▲ +10 B (+0.52% ) 1.95 kB -- -1 B
/blog/april-2019-update ▼ -10 B (-0.32% ) 3.13 kB -- -1 B
/components/pagination ▼ -10 B (-0.12% ) 8.22 kB -- -1 B
/_app -- 37.7 kB -- -1 B
/api-docs/alert-title -- 1.4 kB -- -1 B
/api-docs/alert -- 2.4 kB -- -1 B
/api-docs/app-bar -- 1.94 kB -- -1 B
/api-docs/autocomplete -- 4.62 kB -- -1 B
/api-docs/avatar-group -- 1.51 kB -- -1 B
/api-docs/avatar -- 1.86 kB -- -1 B
/api-docs/backdrop -- 1.73 kB -- -1 B
/api-docs/badge -- 2.13 kB -- -1 B
/api-docs/bottom-navigation-action -- 1.81 kB -- -1 B
/api-docs/bottom-navigation -- 1.7 kB -- -1 B
/api-docs/breadcrumbs -- 1.79 kB -- -1 B
/api-docs/button-base -- 2.22 kB -- -1 B
/api-docs/button-group -- 2.22 kB -- -1 B
/api-docs/button -- 2.53 kB -- -1 B
/api-docs/card-action-area -- 1.58 kB -- -1 B
/api-docs/card-actions -- 1.47 kB -- -1 B
/api-docs/card-content -- 1.45 kB -- -1 B
/api-docs/card-header -- 1.78 kB -- -1 B
/api-docs/card-media -- 1.69 kB -- -1 B
/api-docs/card -- 1.5 kB -- -1 B
/api-docs/checkbox -- 2.3 kB -- -1 B
/api-docs/chip -- 2.46 kB -- -1 B
/api-docs/circular-progress -- 2.07 kB -- -1 B
/api-docs/click-away-listener -- 1.45 kB -- -1 B
/api-docs/collapse -- 2.13 kB -- -1 B
/api-docs/container -- 1.83 kB -- -1 B
/api-docs/css-baseline -- 1.4 kB -- -1 B
/api-docs/dialog-actions -- 1.47 kB -- -1 B
/api-docs/dialog-content-text -- 1.48 kB -- -1 B
/api-docs/dialog-content -- 1.45 kB -- -1 B
/api-docs/dialog-title -- 1.49 kB -- -1 B
/api-docs/dialog -- 2.74 kB -- -1 B
/api-docs/divider -- 1.81 kB -- -1 B
/api-docs/drawer -- 2.13 kB -- -1 B
/api-docs/fab -- 2.1 kB -- -1 B
/api-docs/fade -- 1.5 kB -- -1 B
/api-docs/filled-input -- 2.87 kB -- -1 B
/api-docs/form-control-label -- 1.99 kB -- -1 B
/api-docs/form-control -- 2.36 kB -- -1 B
/api-docs/form-group -- 1.55 kB -- -1 B
/api-docs/form-helper-text -- 1.91 kB -- -1 B
/api-docs/form-label -- 1.84 kB -- -1 B
/api-docs/grid-list-tile-bar -- 1.8 kB -- -1 B
/api-docs/grid-list -- 1.63 kB -- -1 B
/api-docs/grid -- 2.56 kB -- -1 B
/api-docs/grow -- 1.55 kB -- -1 B
/api-docs/hidden -- 1.53 kB -- -1 B
/api-docs/icon-button -- 2.08 kB -- -1 B
/api-docs/icon -- 1.78 kB -- -1 B
/api-docs/input-base -- 2.95 kB -- -1 B
/api-docs/input-label -- 2.07 kB -- -1 B
/api-docs/input -- 2.83 kB -- -1 B
/api-docs/linear-progress -- 2.03 kB -- -1 B
/api-docs/link -- 1.94 kB -- -1 B
/api-docs/list-item-avatar -- 1.51 kB -- -1 B
/api-docs/list-item-icon -- 1.51 kB -- -1 B
/api-docs/list-item-secondary-action -- 1.47 kB -- -1 B
/api-docs/list-item-text -- 1.79 kB -- -1 B
/api-docs/list-item -- 2.25 kB -- -1 B
/api-docs/list-subheader -- 1.77 kB -- -1 B
/api-docs/list -- 1.68 kB -- -1 B
/api-docs/menu-item -- 1.74 kB -- -1 B
/api-docs/menu-list -- 1.57 kB -- -1 B
/api-docs/menu -- 2.42 kB -- -1 B
/api-docs/mobile-stepper -- 1.94 kB -- -1 B
/api-docs/modal -- 2.43 kB -- -1 B
/api-docs/native-select -- 2.11 kB -- -1 B
/api-docs/no-ssr -- 1.3 kB -- -1 B
/api-docs/outlined-input -- 2.98 kB -- -1 B
/api-docs/pagination-item -- 1.97 kB -- -1 B
/api-docs/pagination -- 2.24 kB -- -1 B
/api-docs/paper -- 1.87 kB -- -1 B
/api-docs/popover -- 2.7 kB -- -1 B
/api-docs/popper -- 1.92 kB -- -1 B
/api-docs/portal -- 1.34 kB -- -1 B
/api-docs/radio-group -- 1.45 kB -- -1 B
/api-docs/radio -- 2.12 kB -- -1 B
/api-docs/rating -- 2.49 kB -- -1 B
/api-docs/root-ref -- 1.42 kB -- -1 B
/api-docs/scoped-css-baseline -- 1.4 kB -- -1 B
/api-docs/select -- 2.96 kB -- -1 B
/api-docs/skeleton -- 1.87 kB -- -1 B
/api-docs/slide -- 1.54 kB -- -1 B
/api-docs/slider -- 3.11 kB -- -1 B
/api-docs/snackbar-content -- 1.61 kB -- -1 B
/api-docs/snackbar -- 2.71 kB -- -1 B
/api-docs/speed-dial-action -- 2.04 kB -- -1 B
/api-docs/speed-dial-icon -- 1.55 kB -- -1 B
/api-docs/speed-dial -- 2.32 kB -- -1 B
/api-docs/step-button -- 1.63 kB -- -1 B
/api-docs/step-connector -- 1.54 kB -- -1 B
/api-docs/step-content -- 1.72 kB -- -1 B
/api-docs/step-icon -- 1.57 kB -- -1 B
/api-docs/step-label -- 1.9 kB -- -1 B
/api-docs/step -- 1.64 kB -- -1 B
/api-docs/stepper -- 1.84 kB -- -1 B
/api-docs/svg-icon -- 2.26 kB -- -1 B
/api-docs/swipeable-drawer -- 2.01 kB -- -1 B
/api-docs/switch -- 2.46 kB -- -1 B
/api-docs/tab-context -- 1.08 kB -- -1 B
/api-docs/tab-list -- 1.09 kB -- -1 B
/api-docs/tab-panel -- 1.48 kB -- -1 B
/api-docs/tab-scroll-button -- 1.62 kB -- -1 B
/api-docs/tab -- 1.97 kB -- -1 B
/api-docs/table-body -- 1.47 kB -- -1 B
/api-docs/table-cell -- 2.13 kB -- -1 B
/api-docs/table-container -- 1.48 kB -- -1 B
/api-docs/table-footer -- 1.47 kB -- -1 B
/api-docs/table-head -- 1.46 kB -- -1 B
/api-docs/table-pagination -- 2.47 kB -- -1 B
/api-docs/table-row -- 1.69 kB -- -1 B
/api-docs/table-sort-label -- 1.83 kB -- -1 B
/api-docs/table -- 1.7 kB -- -1 B
/api-docs/tabs -- 2.68 kB -- -1 B
/api-docs/text-field -- 3.18 kB -- -1 B
/api-docs/textarea-autosize -- 1.13 kB -- -1 B
/api-docs/timeline-connector -- 1.4 kB -- -1 B
/api-docs/timeline-content -- 1.43 kB -- -1 B
/api-docs/timeline-dot -- 1.63 kB -- -1 B
/api-docs/timeline-item -- 1.54 kB -- -1 B
/api-docs/timeline-opposite-content -- 1.44 kB -- -1 B
/api-docs/timeline-separator -- 1.4 kB -- -1 B
/api-docs/timeline -- 1.52 kB -- -1 B
/api-docs/toggle-button-group -- 1.92 kB -- -1 B
/api-docs/toggle-button -- 1.79 kB -- -1 B
/api-docs/toolbar -- 1.65 kB -- -1 B
/api-docs/tooltip -- 2.57 kB -- -1 B
/api-docs/tree-item -- 1.89 kB -- -1 B
/api-docs/tree-view -- 1.92 kB -- -1 B
/api-docs/typography -- 2.59 kB -- -1 B
/api-docs/unstable-trap-focus -- 1.46 kB -- -1 B
/api-docs/zoom -- 1.52 kB -- -1 B
/blog/2019-developer-survey-results -- 6.36 kB -- -1 B
/blog/2019 -- 4.25 kB -- -1 B
/blog/2020-introducing-sketch -- 3.52 kB -- -1 B
/blog/2020-q1-update -- 4.34 kB -- -1 B
/blog/august-2019-update -- 2.25 kB -- -1 B
/blog/december-2019-update -- 2.38 kB -- -1 B
/blog/july-2019-update -- 2.14 kB -- -1 B
/blog/june-2019-update -- 2.01 kB -- -1 B
/blog/march-2019-update -- 2.54 kB -- -1 B
/blog/material-ui-v1-is-out -- 6.67 kB -- -1 B
/blog/material-ui-v4-is-out -- 9.69 kB -- -1 B
/blog/may-2019-update -- 2.36 kB -- -1 B
/blog/november-2019-update -- 2.76 kB -- -1 B
/blog/october-2019-update -- 2.51 kB -- -1 B
/blog/september-2019-update -- 2.69 kB -- -1 B
/company/about -- 1.75 kB -- -1 B
/company/contact -- 1.34 kB -- -1 B
/company/jobs -- 1.34 kB -- -1 B
/company/software-engineer -- 5.28 kB -- -1 B
/components/about-the-lab -- 7.91 kB -- -1 B
/components/alert -- 13 kB -- -1 B
/components/app-bar -- 30.2 kB -- -1 B
/components/autocomplete -- 111 kB -- -1 B
/components/avatars -- 9.29 kB -- -1 B
/components/backdrop -- 2.7 kB -- -1 B
/components/badges -- 15.5 kB -- -1 B
/components/bottom-navigation -- 6.25 kB -- -1 B
/components/box -- 8.05 kB -- -1 B
/components/breadcrumbs -- 14.7 kB -- -1 B
/components/button-group -- 7.62 kB -- -1 B
/components/buttons -- 26.7 kB -- -1 B
/components/cards -- 17.3 kB -- -1 B
/components/checkboxes -- 16.5 kB -- -1 B
/components/chips -- 22 kB -- -1 B
/components/click-away-listener -- 4.93 kB -- -1 B
/components/container -- 3.81 kB -- -1 B
/components/css-baseline -- 7.06 kB -- -1 B
/components/dialogs -- 43.1 kB -- -1 B
/components/dividers -- 12.8 kB -- -1 B
/components/drawers -- 31.5 kB -- -1 B
/components/floating-action-button -- 11 kB -- -1 B
/components/grid-list -- 12 kB -- -1 B
/components/grid -- 32.3 kB -- -1 B
/components/hidden -- 10.7 kB -- -1 B
/components/icons -- 27.7 kB -- -1 B
/components/links -- 7.08 kB -- -1 B
/components/lists -- 26.5 kB -- -1 B
/components/material-icons -- 729 kB -- -1 B
/components/menus -- 25.2 kB -- -1 B
/components/modal -- 13 kB -- -1 B
/components/no-ssr -- 5.33 kB -- -1 B
/components/paper -- 3.52 kB -- -1 B
/components/pickers -- 39.3 kB -- -1 B
/components/popover -- 17.6 kB -- -1 B
/components/popper -- 22.6 kB -- -1 B
/components/portal -- 3.16 kB -- -1 B
/components/progress -- 19.3 kB -- -1 B
/components/radio-buttons -- 15.7 kB -- -1 B
/components/rating -- 11 kB -- -1 B
/components/selects -- 33.2 kB -- -1 B
/components/skeleton -- 13.8 kB -- -1 B
/components/slider -- 16.4 kB -- -1 B
/components/snackbars -- 22.4 kB -- -1 B
/components/speed-dial -- 14.7 kB -- -1 B
/components/steppers -- 36.9 kB -- -1 B
/components/switches -- 17 kB -- -1 B
/components/tables -- 174 kB -- -1 B
/components/tabs -- 25.3 kB -- -1 B
/components/text-fields -- 56.6 kB -- -1 B
/components/textarea-autosize -- 3.08 kB -- -1 B
/components/timeline -- 7.31 kB -- -1 B
/components/toggle-button -- 12 kB -- -1 B
/components/tooltips -- 17.7 kB -- -1 B
/components/transfer-list -- 9.73 kB -- -1 B
/components/transitions -- 12.6 kB -- -1 B
/components/tree-view -- 11.6 kB -- -1 B
/components/typography -- 10.1 kB -- -1 B
/components/use-media-query -- 14.1 kB -- -1 B
/customization/breakpoints -- 18 kB -- -1 B
/customization/color -- 19.4 kB -- -1 B
/customization/components -- 38.8 kB -- -1 B
/customization/default-theme -- 8.93 kB -- -1 B
/customization/density -- 10.5 kB -- -1 B
/customization/globals -- 5.24 kB -- -1 B
/customization/palette -- 15.7 kB -- -1 B
/customization/spacing -- 2.83 kB -- -1 B
/customization/theming -- 20.5 kB -- -1 B
/customization/typography -- 14.3 kB -- -1 B
/customization/z-index -- 3.49 kB -- -1 B
/discover-more/backers -- 3.08 kB -- -1 B
/discover-more/changelog -- 1.45 kB -- -1 B
/discover-more/languages -- 3.44 kB -- -1 B
/discover-more/related-projects -- 7.73 kB -- -1 B
/discover-more/roadmap -- 3.72 kB -- -1 B
/discover-more/showcase -- 15.1 kB -- -1 B
/discover-more/team -- 6.84 kB -- -1 B
/discover-more/vision -- 6.76 kB -- -1 B
/getting-started/example-projects -- 7.57 kB -- -1 B
/getting-started/faq -- 34.6 kB -- -1 B
/getting-started/installation -- 7.85 kB -- -1 B
/getting-started/learn -- 9.26 kB -- -1 B
/getting-started/support -- 9.14 kB -- -1 B
/getting-started/supported-platforms -- 6.15 kB -- -1 B
/getting-started/templates -- 8.92 kB -- -1 B
/getting-started/templates/album -- 5.57 kB -- -1 B
/getting-started/templates/blog -- 7.45 kB -- -1 B
/getting-started/templates/checkout -- 10.2 kB -- -1 B
/getting-started/templates/dashboard -- 8.86 kB -- -1 B
/getting-started/templates/pricing -- 7.79 kB -- -1 B
/getting-started/templates/sign-in-side -- 8.21 kB -- -1 B
/getting-started/templates/sign-in -- 8.44 kB -- -1 B
/getting-started/templates/sign-up -- 8.54 kB -- -1 B
/getting-started/templates/sticky-footer -- 1.54 kB -- -1 B
/getting-started/usage -- 9.6 kB -- -1 B
/guides/api -- 14.7 kB -- -1 B
/guides/composition -- 14.9 kB -- -1 B
/guides/flow -- 2.26 kB -- -1 B
/guides/interoperability -- 16 kB -- -1 B
/guides/localization -- 19 kB -- -1 B
/guides/migration-v0x -- 7.51 kB -- -1 B
/guides/migration-v3 -- 19.3 kB -- -1 B
/guides/minimizing-bundle-size -- 11 kB -- -1 B
/guides/responsive-ui -- 4.27 kB -- -1 B
/guides/right-to-left -- 5.24 kB -- -1 B
/guides/server-rendering -- 8.75 kB -- -1 B
/guides/testing -- 8.7 kB -- -1 B
/guides/typescript -- 15.6 kB -- -1 B
/performance/table-component -- 1.44 kB -- -1 B
/performance/table-emotion -- 8.49 kB -- -1 B
/performance/table-hook -- 2.24 kB -- -1 B
/performance/table-mui -- 4.5 kB -- -1 B
/performance/table-raw -- 613 B -- -1 B
/performance/table-styled-components -- 2.6 kB -- -1 B
/premium-themes/onepirate -- 7.34 kB -- -1 B
/premium-themes/onepirate/forgot-password -- 1.01 kB -- -1 B
/premium-themes/onepirate/privacy -- 4.44 kB -- -1 B
/premium-themes/onepirate/sign-in -- 1.07 kB -- -1 B
/premium-themes/onepirate/sign-up -- 1.12 kB -- -1 B
/premium-themes/onepirate/terms -- 11.8 kB -- -1 B
/premium-themes/paperbase -- 7.67 kB -- -1 B
/production-error -- 3.31 kB -- -1 B
/styles/advanced -- 33.7 kB -- -1 B
/styles/api -- 18.1 kB -- -1 B
/styles/basics -- 16.5 kB -- -1 B
/system/api -- 5.98 kB -- -1 B
/system/basics -- 27.6 kB -- -1 B
/system/borders -- 4.13 kB -- -1 B
/system/display -- 6.74 kB -- -1 B
/system/flexbox -- 6.06 kB -- -1 B
/system/palette -- 4.37 kB -- -1 B
/system/positions -- 2.57 kB -- -1 B
/system/shadows -- 3.88 kB -- -1 B
/system/sizing -- 3.58 kB -- -1 B
/system/spacing -- 6.04 kB -- -1 B
/system/typography -- 4.45 kB -- -1 B
/versions -- 23.2 kB -- -1 B
docs:chunk:shared -- 65.8 kB -- -1 B
docs:shared:chunk/commons -- 5.99 kB -- -1 B
docs:shared:chunk/framework -- 42.3 kB -- -1 B
docs:shared:runtime/main -- 6.78 kB -- -1 B
docs:shared:runtime/webpack -- 1.24 kB -- -1 B
bundle Size Change Size Gzip Change Gzip
AccordionSummary ▲ +82.2 kB (+Infinity% ) 82.2 kB ▲ +26 kB (+Infinity% ) 26 kB
Accordion ▲ +77.2 kB (+Infinity% ) 77.2 kB ▲ +24.2 kB (+Infinity% ) 24.2 kB
AccordionActions ▲ +66.5 kB (+Infinity% ) 66.5 kB ▲ +20.8 kB (+Infinity% ) 20.8 kB
AccordionDetails ▲ +66.4 kB (+Infinity% ) 66.4 kB ▲ +20.7 kB (+Infinity% ) 20.7 kB
@material-ui/core ▲ +5.25 kB (+1.42% ) 375 kB ▲ +274 B (+0.27% ) 102 kB
packages/material-ui/material-ui.production.min.js ▲ +4.36 kB (+1.34% ) 330 kB ▲ +734 B (+0.78% ) 95.4 kB
ExpansionPanel ▲ +104 B (+0.13% ) 77.2 kB ▼ -28 B (-0.12% ) 24.2 kB
TextField ▲ +11 B (+0.01% ) 130 kB ▼ -3 B (-0.01% ) 38.2 kB
TablePagination ▲ +10 B (+0.01% ) 148 kB ▲ +8 B (+0.02% ) 43.6 kB
@material-ui/lab ▲ +8 B (0.00% ) 223 kB ▼ -47 B (-0.07% ) 65.6 kB
Collapse ▼ -8 B (-0.01% ) 73.5 kB ▲ +3 B (+0.01% ) 22.7 kB
Menu ▲ +6 B (+0.01% ) 93.9 kB ▼ -13 B (-0.04% ) 28.9 kB
Drawer ▲ +6 B (+0.01% ) 90.4 kB ▼ -5 B (-0.02% ) 27.5 kB
Modal ▲ +3 B (+0.02% ) 15.1 kB ▲ +6 B (+0.11% ) 5.27 kB
IconButton ▼ -3 B (-0.00% ) 80.2 kB -- 25.1 kB
LinearProgress ▲ +2 B (0.00% ) 69.9 kB ▲ +223 B (+1.03% ) 21.8 kB
Slide ▲ +2 B (+0.01% ) 30.7 kB ▲ +136 B (+1.34% ) 10.3 kB
Alert ▼ -2 B (-0.00% ) 87.4 kB ▼ -62 B (-0.22% ) 27.5 kB
MobileStepper ▼ -2 B (-0.00% ) 72.4 kB ▼ -55 B (-0.24% ) 22.6 kB
Snackbar ▼ -2 B (-0.00% ) 80.9 kB ▼ -52 B (-0.20% ) 25.4 kB
Card ▼ -2 B (-0.00% ) 67.3 kB ▼ -18 B (-0.09% ) 21 kB
SnackbarContent ▼ -2 B (-0.00% ) 68 kB ▲ +13 B (+0.06% ) 21.3 kB
AppBar ▼ -2 B (-0.00% ) 68.5 kB ▲ +12 B (+0.06% ) 21.4 kB
Stepper ▼ -2 B (-0.00% ) 69.2 kB ▲ +9 B (+0.04% ) 21.8 kB
Paper ▼ -2 B (-0.00% ) 66.8 kB ▼ -8 B (-0.04% ) 20.8 kB
Popover ▲ +2 B (0.00% ) 88.3 kB ▼ -7 B (-0.03% ) 27.3 kB
FilledInput ▲ +2 B (0.00% ) 78 kB ▼ -6 B (-0.02% ) 24.2 kB
OutlinedInput ▲ +2 B (0.00% ) 79.1 kB ▼ -6 B (-0.02% ) 24.5 kB
FormControl ▲ +2 B (0.00% ) 68.9 kB ▼ -5 B (-0.02% ) 21.4 kB
MenuItem ▲ +2 B (0.00% ) 82.2 kB ▲ +5 B (+0.02% ) 25.7 kB
Tabs ▲ +2 B (0.00% ) 90.2 kB ▼ -5 B (-0.02% ) 28.2 kB
Avatar ▲ +2 B (0.00% ) 69.7 kB ▼ -4 B (-0.02% ) 21.8 kB
FormHelperText ▲ +2 B (0.00% ) 67.8 kB ▼ -4 B (-0.02% ) 21 kB
Tooltip ▲ +2 B (0.00% ) 107 kB ▲ +4 B (+0.01% ) 33.9 kB
FormLabel ▲ +2 B (0.00% ) 68 kB ▼ -3 B (-0.01% ) 21 kB
ListItem ▲ +2 B (0.00% ) 81.1 kB ▲ +3 B (+0.01% ) 25.4 kB
Pagination ▲ +2 B (0.00% ) 88.6 kB ▼ -3 B (-0.01% ) 27.3 kB
RadioGroup ▲ +2 B (0.00% ) 68.4 kB ▲ +3 B (+0.01% ) 21.2 kB
StepIcon ▲ +2 B (0.00% ) 69.1 kB ▼ -3 B (-0.01% ) 21.5 kB
StepLabel ▲ +2 B (0.00% ) 73 kB ▼ -3 B (-0.01% ) 22.6 kB
Backdrop ▲ +2 B (0.00% ) 73.1 kB ▲ +2 B (+0.01% ) 22.6 kB
Fade ▲ +2 B (+0.01% ) 28.9 kB ▲ +2 B (+0.02% ) 9.66 kB
Button ▲ +2 B (0.00% ) 83.8 kB ▼ -1 B (-0.00% ) 25.7 kB
Fab ▲ +2 B (0.00% ) 80.9 kB ▼ -1 B (-0.00% ) 25.2 kB
InputLabel ▲ +2 B (0.00% ) 69.8 kB ▼ -1 B (-0.00% ) 21.5 kB
TabScrollButton ▲ +2 B (0.00% ) 81.1 kB ▲ +1 B (0.00% ) 25.4 kB
Chip ▲ +2 B (0.00% ) 86.8 kB -- 26.6 kB
MenuList ▲ +2 B (0.00% ) 70.5 kB -- 22 kB
PaginationItem ▲ +2 B (0.00% ) 85 kB -- 26.2 kB
Select ▲ +2 B (0.00% ) 121 kB -- 36.1 kB
Input ▲ +1 B (0.00% ) 76.9 kB ▼ -9 B (-0.04% ) 24 kB
InputBase ▲ +1 B (0.00% ) 75 kB ▼ -6 B (-0.03% ) 23.5 kB
SvgIcon ▲ +1 B (0.00% ) 67.5 kB ▼ -4 B (-0.02% ) 21 kB
Grow ▲ +1 B (0.00% ) 29.5 kB ▲ +1 B (+0.01% ) 9.88 kB
Autocomplete ▲ +1 B (0.00% ) 136 kB -- 42.8 kB
TableSortLabel -- 81.5 kB ▼ -95 B (-0.37% ) 25.7 kB
StepButton -- 86.4 kB ▼ -88 B (-0.32% ) 27.2 kB
Checkbox -- 86.3 kB ▲ +64 B (+0.23% ) 27.4 kB
SwipeableDrawer -- 97.8 kB ▲ +63 B (+0.21% ) 30.7 kB
TreeItem -- 80.5 kB ▼ -62 B (-0.24% ) 25.5 kB
Breadcrumbs -- 84.6 kB ▼ -57 B (-0.21% ) 26.7 kB
Switch -- 85.5 kB ▼ -32 B (-0.12% ) 26.8 kB
BottomNavigationAction -- 79.6 kB ▼ -18 B (-0.07% ) 25.2 kB
TimelineDot -- 67.5 kB ▼ -16 B (-0.08% ) 21.1 kB
CircularProgress -- 68.6 kB ▼ -12 B (-0.06% ) 21.6 kB
Radio -- 87.3 kB ▲ +11 B (+0.04% ) 27.6 kB
Slider -- 80.4 kB ▼ -11 B (-0.04% ) 25.5 kB
Tab -- 80.6 kB ▼ -11 B (-0.04% ) 25.6 kB
Box -- 73.3 kB ▼ -9 B (-0.04% ) 22.2 kB
Rating -- 75.3 kB ▼ -9 B (-0.04% ) 24.2 kB
StepContent -- 74.7 kB ▼ -8 B (-0.03% ) 23.3 kB
@material-ui/system -- 17.2 kB ▼ -7 B (-0.15% ) 4.51 kB
ButtonGroup -- 87.5 kB ▼ -7 B (-0.03% ) 27 kB
ExpansionPanelSummary -- 82.2 kB ▲ +7 B (+0.03% ) 26 kB
CardHeader -- 69.6 kB ▼ -6 B (-0.03% ) 21.8 kB
Dialog -- 88.4 kB ▼ -6 B (-0.02% ) 27.6 kB
List -- 66.8 kB ▼ -6 B (-0.03% ) 20.8 kB
TableBody -- 66.6 kB ▼ -6 B (-0.03% ) 20.8 kB
Container -- 67.7 kB ▼ -5 B (-0.02% ) 21.1 kB
Table -- 67 kB ▲ +5 B (+0.02% ) 21 kB
TimelineItem -- 67.6 kB ▼ -5 B (-0.02% ) 21.1 kB
useAutocomplete -- 14.7 kB ▲ +5 B (+0.09% ) 5.27 kB
CardContent -- 66.4 kB ▼ -4 B (-0.02% ) 20.7 kB
Hidden -- 70.5 kB ▲ +4 B (+0.02% ) 22.1 kB
TableHead -- 66.6 kB ▼ -4 B (-0.02% ) 20.8 kB
TabList -- 91.4 kB ▲ +4 B (+0.01% ) 29.2 kB
BottomNavigation -- 66.8 kB ▲ +3 B (+0.01% ) 20.9 kB
Divider -- 67.1 kB ▼ -3 B (-0.01% ) 21.1 kB
ExpansionPanelDetails -- 66.4 kB ▼ -3 B (-0.01% ) 20.7 kB
GridListTileBar -- 67.7 kB ▼ -3 B (-0.01% ) 21.2 kB
InputAdornment -- 69.6 kB ▲ +3 B (+0.01% ) 21.9 kB
ListItemSecondaryAction -- 66.4 kB ▼ -3 B (-0.01% ) 20.8 kB
ListItemText -- 69.5 kB ▼ -3 B (-0.01% ) 21.8 kB
SpeedDialIcon -- 69 kB ▼ -3 B (-0.01% ) 21.6 kB
Step -- 67.2 kB ▲ +3 B (+0.01% ) 21.1 kB
TableFooter -- 66.6 kB ▼ -3 B (-0.01% ) 20.8 kB
TimelineSeparator -- 66.4 kB ▼ -3 B (-0.01% ) 20.8 kB
ToggleButtonGroup -- 67.8 kB ▼ -3 B (-0.01% ) 21.3 kB
Typography -- 68.1 kB ▼ -3 B (-0.01% ) 21.2 kB
Zoom -- 29 kB ▼ -3 B (-0.03% ) 9.8 kB
AvatarGroup -- 70.7 kB ▼ -2 B (-0.01% ) 22.4 kB
CssBaseline -- 66.4 kB ▲ +2 B (+0.01% ) 20.8 kB
Grid -- 69.5 kB ▼ -2 B (-0.01% ) 21.8 kB
Link -- 71.1 kB ▼ -2 B (-0.01% ) 22.4 kB
ListSubheader -- 67.3 kB ▲ +2 B (+0.01% ) 21.1 kB
ScopedCssBaseline -- 67.3 kB ▲ +2 B (+0.01% ) 21.1 kB
Skeleton -- 67.7 kB ▼ -2 B (-0.01% ) 21.3 kB
SpeedDial -- 91.1 kB ▲ +2 B (+0.01% ) 28.9 kB
@material-ui/styles -- 52.1 kB ▲ +1 B (+0.01% ) 15.6 kB
AlertTitle -- 68.7 kB ▲ +1 B (0.00% ) 21.5 kB
Badge -- 69.8 kB ▼ -1 B (-0.00% ) 21.7 kB
ButtonBase -- 78 kB ▲ +1 B (0.00% ) 24.5 kB
CardActionArea -- 79.1 kB ▲ +1 B (0.00% ) 25 kB
CardMedia -- 66.8 kB ▼ -1 B (-0.00% ) 20.9 kB
ClickAwayListener -- 4.13 kB ▲ +1 B (+0.06% ) 1.66 kB
DialogActions -- 66.5 kB ▼ -1 B (-0.00% ) 20.8 kB
DialogContent -- 66.7 kB ▼ -1 B (-0.00% ) 20.8 kB
DialogContentText -- 68.5 kB ▲ +1 B (0.00% ) 21.5 kB
DialogTitle -- 68.8 kB ▲ +1 B (0.00% ) 21.6 kB
FormControlLabel -- 70 kB ▼ -1 B (-0.00% ) 21.9 kB
FormGroup -- 66.4 kB ▼ -1 B (-0.00% ) 20.8 kB
GridList -- 66.9 kB ▲ +1 B (0.00% ) 21 kB
Icon -- 67.3 kB ▼ -1 B (-0.00% ) 21 kB
ListItemAvatar -- 66.5 kB ▼ -1 B (-0.00% ) 20.8 kB
ListItemIcon -- 66.6 kB ▼ -1 B (-0.00% ) 20.8 kB
NativeSelect -- 81.4 kB ▼ -1 B (-0.00% ) 25.6 kB
Popper -- 28.7 kB ▼ -1 B (-0.01% ) 10.3 kB
styles/createMuiTheme -- 21.9 kB ▼ -1 B (-0.01% ) 7.57 kB
TabContext -- 2.65 kB ▼ -1 B (-0.09% ) 1.15 kB
TableCell -- 68.6 kB ▲ +1 B (0.00% ) 21.5 kB
TableRow -- 67 kB ▲ +1 B (0.00% ) 21 kB
TabPanel -- 67.3 kB ▼ -1 B (-0.00% ) 21 kB
Timeline -- 66.9 kB ▼ -1 B (-0.00% ) 20.9 kB
TimelineConnector -- 66.4 kB ▼ -1 B (-0.00% ) 20.8 kB
TimelineContent -- 66.9 kB ▼ -1 B (-0.00% ) 20.9 kB
TimelineOppositeContent -- 67 kB ▼ -1 B (-0.00% ) 20.9 kB
ToggleButton -- 80.2 kB ▲ +1 B (0.00% ) 25.4 kB
TreeView -- 72.8 kB ▼ -1 B (-0.00% ) 22.8 kB
@material-ui/utils -- 7.19 kB -- 2.61 kB
CardActions -- 66.5 kB -- 20.8 kB
colorManipulator -- 4.14 kB -- 1.63 kB
docs:/ -- 12.7 kB -- -1 B
docs:/_app -- 37.7 kB -- -1 B
ExpansionPanelActions -- 66.5 kB -- 20.8 kB
GridListTile -- 68.2 kB -- 21.3 kB
NoSsr -- 2.18 kB -- 1.03 kB
Portal -- 2.87 kB -- 1.29 kB
RootRef -- 4.64 kB -- 1.76 kB
SpeedDialAction -- 123 kB -- 39.1 kB
StepConnector -- 67.2 kB -- 21.1 kB
TableContainer -- 66.4 kB -- 20.7 kB
TextareaAutosize -- 5.23 kB -- 2.19 kB
Toolbar -- 66.8 kB -- 20.9 kB
Unstable_TrapFocus -- 3.85 kB -- 1.59 kB
useMediaQuery -- 2.56 kB -- 1.06 kB
useScrollTrigger -- 2.66 kB -- 1.08 kB

Generated by 🚫 dangerJS against 39b2241

@mbrookes
Copy link
Member

Should we revert the changes in the examples and docs API pages?

I wondered that too, but depending on the timing of the release of this change in v4, it might be helpful to document the new usage, so that developers using it for the first time aren't faced with a breaking change when upgrading to v5.

We could perhaps add a menu Entry for Expansion Panel that links to the Accordion page, with a note on that page that ExpansionPanel has been renamed.

@github-actions github-actions bot mentioned this pull request Jun 24, 2020
Closed
@oliviertassinari
Copy link
Member

oliviertassinari commented Jun 24, 2020 •
edited
Loading

So the plan would be?

  • git cherry-pick 2ddc4ce
  • Add deprecation warning in packages/material-ui/src/ExpansionPanel/index.js, when the component is mounted?
  • Add a Expansion Panel link in the side nav that redirects to /components/accordion/
  • Release the deprecation under a minor version: v4.11.0.

@mbrookes mbrookes changed the title [ExpensionPanel] Make it deprecated, imports should be updated [ExpansionPanel] Rename to Accordion, add warning to current exports Jun 24, 2020
oliviertassinari
oliviertassinari reviewed Jun 25, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, we are almost done, this is the only issue I could spot :)

@oliviertassinari oliviertassinari added the component: accordion This is the name of the generic UI component, not the React module! label Jun 25, 2020
oliviertassinari
oliviertassinari approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add the describe conformance test back as we use it to generate the API. I couldn't spot anything else. Good from my side

@mbrookes
Copy link
Member

mbrookes commented Jun 26, 2020 •
edited
Loading

⚠️ Just a reminder that after merging, we should rename the ExpansionPanel markdown file and directory in the docs before pushing master to staging.

https://crowdin.com/project/material-ui-docs/settings#files

mnajdova and others added 2 commits June 27, 2020 08:35
@mnajdova mnajdova merged commit f279d12 into mui:master Jun 29, 2020
@eps1lon eps1lon mentioned this pull request Aug 5, 2020
Closed
42 tasks
@pelmorex-yyamaguchi pelmorex-yyamaguchi mentioned this pull request Aug 26, 2020
Open
@nfailla
Copy link

nfailla commented Sep 3, 2020

Is there a way to hide these warnings?

@oliviertassinari
Copy link
Member

@nfailla You can downgrade or follow the instructions of the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eps1lon eps1lon eps1lon left review comments

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mbrookes mbrookes mbrookes left review comments

Assignees
No one assigned
Labels
component: accordion This is the name of the generic UI component, not the React module! deprecation New deprecation message
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mnajdova @oliviertassinari @mui-pr-bot @mbrookes @nfailla @eps1lon