Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snackbar] Remove transition onX props #22107

Merged
merged 3 commits into from
Aug 10, 2020

Conversation

mbrookes
Copy link
Member

@mbrookes mbrookes commented Aug 8, 2020

Breaking change

  • The onE* transition props were removed. Use TransitionProps instead.

    <Snackbar
    -  onEnter={onEnter}
    -  onEntered={onEntered},
    -  onEntering={onEntered},
    -  onExit={onEntered},
    -  onExited={onEntered},
    -  onExiting={onEntered}
    +  TransitionProps={{
    +    onEnter,
    +    onEntered,
    +    onEntering,
    +    onExit,
    +    onExited,
    +    onExiting,
    +  }}
    />

#17047 (comment)

@mbrookes mbrookes added breaking change component: snackbar This is the name of the generic UI component, not the React module! labels Aug 8, 2020
@mbrookes mbrookes added this to the v5 milestone Aug 8, 2020
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 8, 2020

Details of bundle changes

Generated by 🚫 dangerJS against c96f6a7

@mbrookes mbrookes marked this pull request as draft August 8, 2020 08:02
eps1lon
eps1lon previously requested changes Aug 8, 2020
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a yarn proptypes which I missed in my PR and then this should go green.

@mbrookes mbrookes marked this pull request as ready for review August 8, 2020 18:39
@oliviertassinari oliviertassinari changed the title [Snackbar] remove transition onX props [Snackbar] Remove transition onX props Aug 9, 2020
@mbrookes mbrookes merged commit ca55d96 into mui:next Aug 10, 2020
@oliviertassinari oliviertassinari mentioned this pull request Sep 15, 2020
42 tasks
@mbrookes mbrookes deleted the snackbar-remove-onX-props branch November 3, 2020 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: snackbar This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants