[Autocomplete] Support readonly type for the options #25155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
component: autocomplete
oliviertassinari
changed the title
oliviertassinari
changed the title
oliviertassinari
approved these changes
Mar 1, 2021
eps1lon
approved these changes
Mar 2, 2021
|
@silver-snoopy Thanks for taking the time to look into testing this. It's refreshing to see a contribution form the community that does it right, without needing a maintainer to guide them all the way :) |
|
Thanks @oliviertassinari @eps1lon !! |
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is aiming to fix: #24639
Description
Additional information
There is two possible solution to address this:
ReadonlyArray<T>andT[] | Readonly<T[]>I took the former, but happy to change it to to latter if it is more aligned with the the project directives.