-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][base-ui][TablePagination] Accept readonly array for rowsPerPageOptions
prop
#40481
Conversation
pcorpet
commented
Jan 8, 2024
- I have followed (at least) the PR section of the contributing guide.
Netlify deploy previewhttps://deploy-preview-40481--material-ui.netlify.app/ Bundle size report |
The direction looks good, same as #25155. I don't know if we need a test case for this. It even looks like we should do this change everywhere in the codebase while we are at it. For example:
|
I'm just a humble user of MUI and didn't want to move too many things at once. Do you want me to do that in that PR as well? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rowsPerPageOptions
prop