Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Container] Fix support for custom breakpoints #26328

Merged
merged 7 commits into from
May 17, 2021
Merged

[Container] Fix support for custom breakpoints #26328

merged 7 commits into from
May 17, 2021

Conversation

alanszp
Copy link
Contributor

@alanszp alanszp commented May 16, 2021 •
edited by oliviertassinari
Loading

With this PR I'm fixing the Container component when you define custom breakpoints.

Used the patch code by @oliviertassinari in this fix #21745

Also, run tests & try it in my own project. Everything working 💯

@mui-pr-bot
Copy link

mui-pr-bot commented May 16, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 614fdfd

@github-actions github-actions bot mentioned this pull request May 16, 2021
Closed
@oliviertassinari oliviertassinari changed the title [Container] Fix Typescript compilation with custom breakpoints [Container] Fix support with custom breakpoints May 16, 2021
@oliviertassinari oliviertassinari changed the title [Container] Fix support with custom breakpoints [Container] Fix support for custom breakpoints May 16, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work and removed typescript labels May 16, 2021
@alanszp
Copy link
Contributor Author

alanszp commented May 16, 2021

@oliviertassinari saw that other components are autogenerating the PropTypes with yarn proptypes but Container is not.

Is it ok?

@alanszp alanszp mentioned this pull request May 16, 2021
Closed
2 tasks
@oliviertassinari
Copy link
Member

@alanszp It's OK.

mnajdova
mnajdova approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alanszp

It's a great firsrt pull request on Material-UI 👌 Thanks for working on it.

@mnajdova mnajdova merged commit 8a291d6 into mui:next May 17, 2021
@mnajdova mnajdova mentioned this pull request May 17, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Container The React component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS Media Queries don't work with Custom breakpoints
4 participants
@alanszp @mui-pr-bot @oliviertassinari @mnajdova