Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] Fix support for custom breakpoints #26331

Merged
merged 2 commits into from
May 19, 2021
Merged

[Dialog] Fix support for custom breakpoints #26331

merged 2 commits into from
May 19, 2021

Conversation

jeferson-sb
Copy link
Contributor

@jeferson-sb jeferson-sb commented May 17, 2021 •
edited by oliviertassinari
Loading

Update Dialog typings to accept custom breakpoints on maxWidth by using Breakpoint utility.

Tests run with yarn test and yarn proptypes

Closes #26330

@mui-pr-bot
Copy link

mui-pr-bot commented May 17, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against 37ec16c

@mnajdova
Copy link
Member

mnajdova commented May 17, 2021 •
edited
Loading

@jeferson-sb could you rebase and add a test case, as done in #26328? Apart from that looks good 👍

@alanszp alanszp mentioned this pull request May 17, 2021
Closed
2 tasks
@oliviertassinari oliviertassinari changed the title [Dialog] Add typescript support for custom breakpoints [Dialog] Add support for custom breakpoints May 17, 2021
@oliviertassinari oliviertassinari added the component: dialog This is the name of the generic UI component, not the React module! label May 17, 2021
@oliviertassinari oliviertassinari force-pushed the update-dialog-to-custom-breakpoints branch from 860b58d to 37ec16c Compare May 18, 2021 21:10
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label May 18, 2021
@oliviertassinari oliviertassinari changed the title [Dialog] Add support for custom breakpoints [Dialog] Fix support for custom breakpoints May 18, 2021
@github-actions github-actions bot mentioned this pull request May 18, 2021
Closed
@oliviertassinari oliviertassinari merged commit 13ad61a into mui:next May 19, 2021
@oliviertassinari
Copy link
Member

@jeferson-sb Thanks for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Dialog] Fix typescript support for custom breakpoints
4 participants
@jeferson-sb @mui-pr-bot @mnajdova @oliviertassinari