Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][docs] Improve TabContext, TabList, and TabPanel documentation #40587

Merged

Conversation

anle9650
Copy link
Contributor

@anle9650 anle9650 commented Jan 14, 2024

@mui-bot
Copy link

mui-bot commented Jan 14, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against dd7a7e7

@anle9650 anle9650 changed the title [material-ui][Tabs] Improve TabContext, TabList, and TabPanel documentation [material-ui][docs] Improve TabContext, TabList, and TabPanel documentation Jan 14, 2024
@zannager zannager added docs Improvements or additions to the documentation package: material-ui Specific to @mui/material labels Jan 15, 2024
Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent improvement!

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, @anle9650! 🚀

What do you think about moving the lab components (List, Panel, Context) into the Experimental API section? I think it would be confusing to have these explained in the Introduction section and then not used in that section's demo

@anle9650
Copy link
Contributor Author

^ agreed, that makes sense to me!

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks @anle9650

@DiegoAndai DiegoAndai merged commit 23a9e24 into mui:master Jan 17, 2024
19 checks passed
@samuelsycamore
Copy link
Contributor

Good catch @DiegoAndai ! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Tabs] Improve TabContext, TabList, and TabPanel documentation
5 participants