Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][docs] Add docs for complementary Dialog components #41313

Merged
merged 5 commits into from
Mar 12, 2024
Merged

[material-ui][docs] Add docs for complementary Dialog components #41313

merged 5 commits into from
Mar 12, 2024

Conversation

jwithington
Copy link
Contributor

Part of #39952 .

Please note that I did end up cutting some existing content / rearranging some things based on the work I saw in #40587, #40346, and in some of the existing docs elsewhere.

Thanks!

@mui-bot
Copy link

mui-bot commented Feb 29, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 47c1cb5

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Feb 29, 2024
@anle9650 anle9650 mentioned this pull request Mar 2, 2024
Open
samuelsycamore
samuelsycamore reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@samuelsycamore samuelsycamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jwithington !

docs/data/material/components/dialogs/dialogs.md Outdated Show resolved Hide resolved
docs/data/material/components/dialogs/dialogs.md Outdated Show resolved Hide resolved
@samuelsycamore
Apply suggestions from code review
47c1cb5 
Signed-off-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
@samuelsycamore samuelsycamore merged commit 7e71e6c into mui:master Mar 12, 2024
19 checks passed
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
@Chanuth-silva10 Chanuth-silva10 mentioned this pull request May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
@sergivj sergivj mentioned this pull request May 21, 2024
Open
This was referenced May 21, 2024
Open
Open
@RTHariSankar RTHariSankar mentioned this pull request May 21, 2024
Open
@GitLukeW GitLukeW mentioned this pull request May 21, 2024
Open
@amylank22 amylank22 mentioned this pull request May 21, 2024
Open
@aqibawan12 aqibawan12 mentioned this pull request May 21, 2024
Open
@Poseidon-G Poseidon-G mentioned this pull request May 21, 2024
Open
@Crushoverride007 Crushoverride007 mentioned this pull request May 21, 2024
Open
@mx1613 mx1613 mentioned this pull request May 21, 2024
Closed
@DanneelsSophie DanneelsSophie mentioned this pull request May 22, 2024
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelsycamore samuelsycamore samuelsycamore approved these changes

Assignees
No one assigned
Labels
component: dialog This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwithington @mui-bot @samuelsycamore @danilo-leal