-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Update pricing table #41595
Conversation
Netlify deploy previewhttps://deploy-preview-41595--material-ui.netlify.app/ Bundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we list all the pickers' components in the expandable "Date and Time Pickers" section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it will improve the clarity that way. 🤔
WDYT about doing the following renaming?
Date Picker
->Date and Time Pickers
Date Range Picker
->Date and Time Range Pickers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better than the current version, although where should we link them?
Date and Time Pickers
Date and Time Range Pickers
Does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need/want to add links, I'd say that they should lead to the most simple Picker components:
Date and Time Pickers
Date and Time Range Pickers
However, I'm not sure we need links here...
WDYT @joserodolfofreitas @flaviendelangle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we had to choose one component to link to, I would indeed choose DatePicker and DateRangePicker
But maybe we lack a section to actually link to...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we had to choose one component to link to, I would indeed choose DatePicker and DateRangePicker
But maybe we lack a section to actually link to...
@@ -869,6 +879,9 @@ const proData: Record<string, React.ReactNode> = { | |||
'charts/filter-interaction': pending, | |||
'charts/selection-interaction': no, | |||
|
|||
'tree-view/simple-tree-view': yes, | |||
'tree-view/rich-tree-view': yes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joserodolfofreitas we can prepare a follow up with upcoming tree view pro features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for tackling this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! 💯
To reflect the MUI X v7 offering.
Preview: https://deploy-preview-41595--material-ui.netlify.app/pricing/
TODO:
Add more pickers to the pricing table?master