-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Update pricing table #41595
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5c65476
update data grid pricing
cherniavskii 5f54eff
update charts pricing
cherniavskii 55de1c8
add tree view to the pricing table
cherniavskii 1cffde6
Merge branch 'next' into update-pricing
cherniavskii da8a53f
link to the pickers docs
cherniavskii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -564,8 +564,15 @@ const rowHeaders: Record<string, React.ReactNode> = { | |
'data-grid/localization': ( | ||
<ColumnHead label="Localization" href="/x/react-data-grid/localization/" /> | ||
), | ||
'date-picker/simple': <ColumnHead label="Date Picker" />, | ||
'date-picker/range': <ColumnHead label="Date Range Picker" />, | ||
'date-picker/simple': ( | ||
<ColumnHead label="Date and Time Pickers" href="/x/react-date-pickers/date-picker/" /> | ||
), | ||
'date-picker/range': ( | ||
<ColumnHead | ||
label="Date and Time Range Pickers" | ||
href="/x/react-date-pickers/date-range-picker/" | ||
/> | ||
), | ||
|
||
// -- charts - components -- | ||
'charts/line': <ColumnHead label="Line chart" href="/x/react-charts/lines/" />, | ||
|
@@ -595,6 +602,13 @@ const rowHeaders: Record<string, React.ReactNode> = { | |
'charts/filter-interaction': <ColumnHead label="Row filtering" />, | ||
'charts/selection-interaction': <ColumnHead label="Range selection" />, | ||
|
||
'tree-view/simple-tree-view': ( | ||
<ColumnHead label="Simple Tree View" href="/x/react-tree-view/#simple-tree-view" /> | ||
), | ||
'tree-view/rich-tree-view': ( | ||
<ColumnHead label="Rich Tree View" href="/x/react-tree-view/#rich-tree-view" /> | ||
), | ||
|
||
'mui-x-production': <ColumnHead label="Perpetual use in production" />, | ||
'mui-x-development': <ColumnHead label="Development license" tooltip="For active development" />, | ||
'mui-x-development-perpetual': ( | ||
|
@@ -701,8 +715,8 @@ const communityData: Record<string, React.ReactNode> = { | |
// -- data grid - columns -- | ||
'data-grid/column-groups': yes, | ||
'data-grid/column-spanning': yes, | ||
'data-grid/column-resizing': no, | ||
'data-grid/column-autosizing': no, | ||
'data-grid/column-resizing': yes, | ||
'data-grid/column-autosizing': yes, | ||
'data-grid/column-reorder': no, | ||
'data-grid/column-pinning': no, | ||
// -- data grid - rows -- | ||
|
@@ -753,7 +767,7 @@ const communityData: Record<string, React.ReactNode> = { | |
'charts/scatter': yes, | ||
'charts/pie': yes, | ||
'charts/sparkline': yes, | ||
'charts/gauge': pending, | ||
'charts/gauge': yes, | ||
'charts/treemap': pending, | ||
'charts/heatmap': no, | ||
'charts/radar': pending, | ||
|
@@ -773,6 +787,9 @@ const communityData: Record<string, React.ReactNode> = { | |
'charts/filter-interaction': no, | ||
'charts/selection-interaction': no, | ||
|
||
'tree-view/simple-tree-view': yes, | ||
'tree-view/rich-tree-view': yes, | ||
|
||
// -- general -- | ||
'mui-x-production': yes, | ||
'mui-x-updates': yes, | ||
|
@@ -849,7 +866,7 @@ const proData: Record<string, React.ReactNode> = { | |
'charts/scatter': yes, | ||
'charts/pie': yes, | ||
'charts/sparkline': yes, | ||
'charts/gauge': pending, | ||
'charts/gauge': yes, | ||
'charts/treemap': pending, | ||
'charts/heatmap': pending, | ||
'charts/radar': pending, | ||
|
@@ -869,6 +886,9 @@ const proData: Record<string, React.ReactNode> = { | |
'charts/filter-interaction': pending, | ||
'charts/selection-interaction': no, | ||
|
||
'tree-view/simple-tree-view': yes, | ||
'tree-view/rich-tree-view': yes, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @joserodolfofreitas we can prepare a follow up with upcoming tree view pro features |
||
|
||
// -- general -- | ||
'mui-x-production': yes, | ||
'mui-x-development': <Info value="1 year" />, | ||
|
@@ -950,7 +970,7 @@ const premiumData: Record<string, React.ReactNode> = { | |
'charts/scatter': yes, | ||
'charts/pie': yes, | ||
'charts/sparkline': yes, | ||
'charts/gauge': pending, | ||
'charts/gauge': yes, | ||
'charts/treemap': pending, | ||
'charts/heatmap': pending, | ||
'charts/radar': pending, | ||
|
@@ -970,6 +990,9 @@ const premiumData: Record<string, React.ReactNode> = { | |
'charts/filter-interaction': pending, | ||
'charts/selection-interaction': pending, | ||
|
||
'tree-view/simple-tree-view': yes, | ||
'tree-view/rich-tree-view': yes, | ||
|
||
// -- general -- | ||
'mui-x-production': yes, | ||
'mui-x-development': <Info value="1 year" />, | ||
|
@@ -1565,6 +1588,10 @@ export default function PricingTable({ | |
{renderNestedRow('charts/selection-interaction')} | ||
</StyledCollapse> | ||
{divider} | ||
{renderRow('tree-view/simple-tree-view')} | ||
{divider} | ||
{renderRow('tree-view/rich-tree-view')} | ||
{divider} | ||
{renderRow('mui-x-production')} | ||
{divider} | ||
<PricingTableDevelopment renderRow={renderRow} /> | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we list all the pickers' components in the expandable "Date and Time Pickers" section?
cc @flaviendelangle @LukasTy @joserodolfofreitas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it will improve the clarity that way. 🤔
WDYT about doing the following renaming?
Date Picker
->Date and Time Pickers
Date Range Picker
->Date and Time Range Pickers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better than the current version, although where should we link them?
Date and Time Pickers
Date and Time Range Pickers
Does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we need/want to add links, I'd say that they should lead to the most simple Picker components:
Date and Time Pickers
Date and Time Range Pickers
However, I'm not sure we need links here...
WDYT @joserodolfofreitas @flaviendelangle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we had to choose one component to link to, I would indeed choose DatePicker and DateRangePicker
But maybe we lack a section to actually link to...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 👍🏻