[material-ui][mui-system] Refactor types so they're compatible with upcoming React 19 #43276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
package: system
Netlify deploy previewhttps://deploy-preview-43276--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
DiegoAndai
force-pushed
the
react-19-compatibility-types
branch
2 times, most recently
from
8accaca
to
869ff4c
Compare
DiegoAndai
force-pushed
the
react-19-compatibility-types
branch
from
869ff4c
to
0254d0a
Compare
1 task
34 tasks
DiegoAndai
added a commit
to DiegoAndai/material-ui
that referenced
this pull request
Nov 27, 2024
…pcoming React 19 (mui#43276)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #42824
This PR takes out most of the type changes from #42824. The only changes we cannot take out are:
MutableRefObjectwithRefObject(for example, this one). We cannot change this asRefObjectis immutable in React 18 and prior, so it would introduce an immutable type in v5 that wasn't there before.refis not passed as a prop in React 18Here are codesandboxes to check that the
useReftypes are indeed compatible: