Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v5] Support React 19 in Material UI v5 #44413

Closed
37 tasks done
Tracked by #42381
DiegoAndai opened this issue Nov 14, 2024 · 6 comments
Closed
37 tasks done
Tracked by #42381

[v5] Support React 19 in Material UI v5 #44413

DiegoAndai opened this issue Nov 14, 2024 · 6 comments
Assignees
Labels
package: material-ui Specific to @mui/material v5.x

Comments

@DiegoAndai
Copy link
Member

DiegoAndai commented Nov 14, 2024

Backport the React 19 related changes from v6 to v5 so we support the upcoming React release on v5.

List of PRs to backport (Merged | Open):

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 14, 2024
@DiegoAndai DiegoAndai changed the title Backport fixes to Material UI v5 [core] Backport React 19 changes to Material UI v5 Nov 14, 2024
@DiegoAndai DiegoAndai added package: material-ui Specific to @mui/material and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 14, 2024
@DiegoAndai DiegoAndai changed the title [core] Backport React 19 changes to Material UI v5 [material-ui] Backport React 19 changes to Material UI v5 Nov 14, 2024
@DiegoAndai DiegoAndai self-assigned this Nov 14, 2024
@DiegoAndai DiegoAndai moved this to Selected in Material UI Nov 14, 2024
@DiegoAndai DiegoAndai moved this from Selected to In progress in Material UI Nov 15, 2024
@DiegoAndai DiegoAndai added the on hold There is a blocker, we need to wait label Nov 27, 2024
@DiegoAndai
Copy link
Member Author

On hold until React 19 is stable and #42824 is merged. With the already backported changes, users should be ready to start trying v5 with React 19.

@oliviertassinari oliviertassinari changed the title [material-ui] Backport React 19 changes to Material UI v5 [v5] Support React 19 in Material UI v5 Dec 3, 2024
@oliviertassinari oliviertassinari added v5.x React 19 support PRs required to support React 19 labels Dec 3, 2024
@DiegoAndai DiegoAndai removed the React 19 support PRs required to support React 19 label Dec 9, 2024
@DiegoAndai DiegoAndai removed the on hold There is a blocker, we need to wait label Dec 9, 2024
@julianCast
Copy link

Hi! Any updates when this will be released? v5 or v6? Thanks!

@DiegoAndai
Copy link
Member Author

Hey @julianCast, this was already released in v6.

Expect the v5 release early next week. That being said, you should already be able to use v5 with React 19; the only thing missing is some internal dependency changes.

@julianCast
Copy link

julianCast commented Dec 13, 2024

Hey @julianCast, this was already released in v6.

Expect the v5 release early next week. That being said, you should already be able to use v5 with React 19; the only thing missing is some internal dependency changes.

Thank you. I'm guessing one of those deps will be react-transition-group ? We are using v5.2.7 and after updating to React 19 we are getting:

Type error: Type 'React.ReactNode' is not assignable to type 'import("/Users/julian/Documents/GitHub/mycell/frontend/packages/opsa/node_modules/@types/react-transition-group/node_modules/@types/react/index").ReactNode'.

import { Autocomplete } from "@mui/material";
  Type 'bigint' is not assignable to type 'ReactNode'.
 							<Autocomplete
 							  ...
 							   renderGroup={(params) => (
  221 |                       <li key={params.key}>
  222 |                         <GroupHeader>{params.group}</GroupHeader>
> 223 |                         <GroupItems>{params.children}</GroupItems>
      |                                     ^
  224 |                       </li>

@DiegoAndai
Copy link
Member Author

Just released @mui/material@5.16.12 which includes all the required backports from v6 to support React 19.

I'm closing this as completed. If you find any React 19 related issues with v5, please open a new issue with a minimal reproduction.

@julianCast we haven't found this type error in our tests. May I ask you to open a new issue for it so we can debug it? Thanks.

@github-project-automation github-project-automation bot moved this from In progress to Done in Material UI Dec 17, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: material-ui Specific to @mui/material v5.x
Projects
Status: Done
Development

No branches or pull requests

3 participants