-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Bump React to 18.3.1 #42846
[core] Bump React to 18.3.1 #42846
Conversation
Netlify deploy previewhttps://deploy-preview-42846--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
9c5333a
to
61dc4fa
Compare
Co-authored-by: Aarón García Hervás <aaron@mui.com>
601d6d9
to
e4402fa
Compare
Finally a bump of @testing-library/dom and @testing-library/react was required to have a compatible React 18.3.1 testing setup, otherwise tests would fail due to some wrong types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Contents of this PR:
act
is no longer exported fromreact-dom/test-utils
and is now exported fromreact
. Older versions of@testing-library/react
point toact
inreact-dom/test-utils
, so we need to upgrade to a newer version. This can't be done in a separate PR because of some incompatible types.We're backporting all changes to support React 18.3.1 from
next
tomaster
. These are the changes to backport fromnext
before we can merge this PR:defaultProptypes
warning. Included in this PR.