-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joy-ui][Autocomplete] Fix React spread key warning #42741
Merged
aarongarciah
merged 1 commit into
mui:next
from
aarongarciah:fix-joy-autocomplete-spread-key
Jun 24, 2024
Merged
[joy-ui][Autocomplete] Fix React spread key warning #42741
aarongarciah
merged 1 commit into
mui:next
from
aarongarciah:fix-joy-autocomplete-spread-key
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
typescript
package: joy-ui
Specific to @mui/joy
React 19 support
PRs required to support React 19
labels
Jun 24, 2024
aarongarciah
changed the title
[joy-ui][Autocomplete] Fix React key spread warnings
[joy-ui][Autocomplete] Fix React spread key warning
Jun 24, 2024
Netlify deploy previewhttps://deploy-preview-42741--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Fixing this is required to land #42047 |
DiegoAndai
approved these changes
Jun 24, 2024
15 tasks
aarongarciah
added
the
cherry-pick
The PR was cherry-picked from the newer alpha/beta/stable branch
label
Jun 24, 2024
aarongarciah
removed
the
cherry-pick
The PR was cherry-picked from the newer alpha/beta/stable branch
label
Jul 5, 2024
13 tasks
aarongarciah
added a commit
to aarongarciah/material-ui
that referenced
this pull request
Jul 5, 2024
aarongarciah
added a commit
to aarongarciah/material-ui
that referenced
this pull request
Jul 5, 2024
aarongarciah
added
component: autocomplete
This is the name of the generic UI component, not the React module!
and removed
typescript
labels
Jul 5, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: autocomplete
This is the name of the generic UI component, not the React module!
package: joy-ui
Specific to @mui/joy
React 19 support
PRs required to support React 19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a React 18.3 warning when using
renderTags
props in Joy's Autocomplete component:Note: some Joy's Autocomplete demos throw the same warning in the browser, but that's not part of the component source code and should be solved separately.