Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][Autocomplete] Fix React spread key warning #42741

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

aarongarciah
Copy link
Member

@aarongarciah aarongarciah commented Jun 24, 2024

Fixes a React 18.3 warning when using renderTags props in Joy's Autocomplete component:

A props object containing a "key" prop is being spread into JSX

Note: some Joy's Autocomplete demos throw the same warning in the browser, but that's not part of the component source code and should be solved separately.

@aarongarciah aarongarciah added typescript package: joy-ui Specific to @mui/joy React 19 support PRs required to support React 19 labels Jun 24, 2024
@aarongarciah aarongarciah requested a review from DiegoAndai June 24, 2024 15:03
@aarongarciah aarongarciah changed the title [joy-ui][Autocomplete] Fix React key spread warnings [joy-ui][Autocomplete] Fix React spread key warning Jun 24, 2024
@mui-bot
Copy link

mui-bot commented Jun 24, 2024

Netlify deploy preview

https://deploy-preview-42741--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against b6d8c0e

@aarongarciah
Copy link
Member Author

Fixing this is required to land #42047

@aarongarciah aarongarciah mentioned this pull request Jun 24, 2024
15 tasks
@aarongarciah aarongarciah added the cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch label Jun 24, 2024
@aarongarciah aarongarciah merged commit 3d10564 into mui:next Jun 24, 2024
23 checks passed
@aarongarciah aarongarciah deleted the fix-joy-autocomplete-spread-key branch June 24, 2024 16:02
@aarongarciah aarongarciah removed the cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch label Jul 5, 2024
@aarongarciah aarongarciah mentioned this pull request Jul 5, 2024
13 tasks
aarongarciah added a commit to aarongarciah/material-ui that referenced this pull request Jul 5, 2024
aarongarciah added a commit to aarongarciah/material-ui that referenced this pull request Jul 5, 2024
@aarongarciah aarongarciah added component: autocomplete This is the name of the generic UI component, not the React module! and removed typescript labels Jul 5, 2024
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy React 19 support PRs required to support React 19
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants