Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui] Fix React spread key warning in test #42744

Merged
merged 1 commit into from
Jun 24, 2024
Merged

[base-ui] Fix React spread key warning in test #42744

merged 1 commit into from
Jun 24, 2024

Conversation

aarongarciah
Copy link
Member

Fixes a React 18.3 warning in a useAutocomplete test:

A props object containing a "key" prop is being spread into JSX

@aarongarciah aarongarciah added package: base-ui Specific to @mui/base port-to-base-ui PR to be included in the Base UI repository once the API changes are done cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch React 19 support PRs required to support React 19 labels Jun 24, 2024
@aarongarciah aarongarciah requested a review from DiegoAndai June 24, 2024 16:07
@aarongarciah aarongarciah mentioned this pull request Jun 24, 2024
Merged
15 tasks
@mui-bot
Copy link

mui-bot commented Jun 24, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-42744--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d93d938

DiegoAndai
DiegoAndai approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how we missed this one in https://github.com/mui/material-ui/pull/42241/files 🤔

@aarongarciah
Copy link
Member Author

@DiegoAndai same!

@aarongarciah aarongarciah merged commit 00c1b90 into mui:next Jun 24, 2024
23 checks passed
@aarongarciah aarongarciah deleted the fix-use-autocomplete-spread-key branch June 24, 2024 16:44
@aarongarciah aarongarciah removed the cherry-pick The PR was cherry-picked from the newer alpha/beta/stable branch label Jul 5, 2024
@aarongarciah aarongarciah mentioned this pull request Jul 5, 2024
Merged
13 tasks
aarongarciah added a commit to aarongarciah/material-ui that referenced this pull request Jul 5, 2024
@aarongarciah
[base-ui] Fix React spread key warning in test (mui#42744)
02e7d31
aarongarciah added a commit to aarongarciah/material-ui that referenced this pull request Jul 5, 2024
@aarongarciah
[base-ui] Fix React spread key warning in test (mui#42744)
f574bbd
@aarongarciah aarongarciah added the component: autocomplete This is the name of the generic UI component, not the React module! label Jul 5, 2024
@aarongarciah aarongarciah mentioned this pull request Jul 5, 2024
Merged
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
@aarongarciah @joserodolfofreitas
[base-ui] Fix React spread key warning in test (mui#42744)
5118441
@DiegoAndai DiegoAndai mentioned this pull request Nov 15, 2024
Closed
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
component: autocomplete This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base port-to-base-ui PR to be included in the Base UI repository once the API changes are done React 19 support PRs required to support React 19
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aarongarciah @mui-bot @DiegoAndai