-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[system] Make createGrid compatible with React 19 types #44035
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
package: system
Specific to @mui/system
React 19 support
PRs required to support React 19
typescript
labels
Oct 7, 2024
Netlify deploy previewhttps://deploy-preview-44035--material-ui.netlify.app/ Bundle size report |
Janpot
reviewed
Oct 8, 2024
Janpot
approved these changes
Oct 8, 2024
This was referenced Oct 31, 2024
Merged
37 tasks
DiegoAndai
pushed a commit
to DiegoAndai/material-ui
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package: system
Specific to @mui/system
React 19 support
PRs required to support React 19
typescript
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #42824. Solves a type error when using React 19 types: https://app.circleci.com/pipelines/github/mui/material-ui/140604/workflows/447f7cd0-c11d-4220-a27d-822a76ec6576/jobs/757885