[utils] Make getReactElementRef React 19 compatible #44034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongarciah
added
package: utils
Netlify deploy previewhttps://deploy-preview-44034--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
aarongarciah
commented
Oct 7, 2024
| export default function getReactElementRef( | ||
| element: React.ReactElement, | ||
| ): React.Ref<any> | null | undefined { | ||
| export default function getReactElementRef(element: React.ReactElement): React.Ref<any> | null { |
There was a problem hiding this comment.
The function now returns a ref or null, no more undefined. This makes it behave the same in React 18 and React 19. Before this PR, in React 18 it returned undefined in some scenarios and in React 19 it returned null for the same scenarios.
aarongarciah
commented
Oct 7, 2024
| // 'ref' is passed as prop in React 19, whereas 'ref' is directly attached to children in older versions | ||
| if (parseInt(React.version, 10) >= 19) { | ||
| return element.props?.ref; | ||
| return (element?.props as any)?.ref || null; |
There was a problem hiding this comment.
Apart from making it return null when there's no ref, two other changes in this line:
element.propsis unknown so we need to cast it. With React 19 types, TS reports this error:Property 'ref' does not exist on type '{}'- Optional chaining added to
elementso it doesn't fail in test cases where the value passed in undefined (getReactElementRef())
This was referenced Oct 31, 2024
Merged
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #42824