[infra] Add closing message workflow

[michelengelen]

• I have followed (at least) the PR section of the contributing guide.

Adds the reusable workflow of adding a message on closed issues (like in thew x repo)

This is using a reusable workflow to decrease friction on changes.

[mui-bot]

Netlify deploy preview

https://deploy-preview-43450--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 0dde9b5

[mnajdova]

Is this comment left only when the issue is resolved/fixed?

[michelengelen]

Is this comment left only when the issue is resolved/fixed?

It's always left ... you don't seem to use the stale issue workflow, right?
In that case we would skip that message, since it gets closed with a different closingReason

[michelengelen]

we could probably adjust this to not post the comment, when the issue is closed as won't do ... i'll check that ... but this would mean just a tiny adjustment in this workflow file

[michelengelen]

@mnajdova b67700b

[mnajdova]

I meant we likely shouldn't leave it if for example if it has the labels: "status: waiting for author", "duplicated", "support: StackOverflow" etc. We are leaving different messages in these scenarios.

[mnajdova]

We need to check how are the issues closed in these scenarios (the manual one should be already covered by your last commit).

[michelengelen]

OK, I just looked over the workflows in this repo and it seems you close for a few reasons:

1. Inactivity: Same as with X, so the behavior is the same => no closing message
2. Stackoverflow support: This closes the issue and would potentially add the closing message. This change 8382256 fixes that
3. Marked as duplicate: This is by default marked as 'not_planned' by the action, so we are good there as well.

I could not find any other scenarios, so considering these and the manual action is also covered we should be good with these changes, right? 😄

[mnajdova]

This is what needed to be checked, nice!

[oliviertassinari]

We should roll this change to all the other repositories, right? I imagine it's about https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/.

I'm also not sure how to feel about not asking for support feedback on an issue we closed as not planned. I guess it makes sense, what we would get is mostly people not happy 😄. Kind of https://www.oesterlund.dev/blog/learnings-from-one-year-of-building-an-open-source-project#learning-2-dont-even-try-to-please-everyone, built a system that makes us default to not try to please everyone.

[michelengelen]

Yes, the plan is to roll this out to all repos that have at least some user visibility.

[mnajdova]

Cool, let's try this! Thanks 🙏

[mnajdova]

I created #43451 to fix the CI issue, @siriwatknp is handling the other changes needed for the stable release

[mnajdova]

@michelengelen you can update to latest master and merge, the CI blocker was just merged.

[aarongarciah]

@michelengelen I started receiving these email notifications, is there a way to avoid them?

[michelengelen]

@michelengelen I started receiving these email notifications, is there a way to avoid them?

You should just unsubscribe from the workflow runs... you can do that in the GitHub settings.

[aarongarciah]

@michelengelen yeah, I can unsubscribe from workflow runs notifications, but I like to be notified about failed workflows. I guess the question is: why is this particular workflow failing? These notifications can be very noisy as I think I'm receiving one for every commit pushed to any given PR.

[michelengelen]

@michelengelen yeah, I can unsubscribe from workflow runs notifications, but I like to be notified about failed workflows. I guess the question is: why is this particular workflow failing? These notifications can be very noisy as I think I'm receiving one for every commit pushed to any given PR.

With #43464 this should not fail anymore! 👍🏼

I thought you can unsubscribe from specific workflows as well, but that might not be the case!

[aarongarciah]

Awesome, thank you!