Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Add closing message workflow #43450

Merged
merged 5 commits into from
Aug 26, 2024
Merged

[infra] Add closing message workflow #43450

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a23bbf2
added closed issue message workflow
michelengelen Aug 26, 2024
9284568
changed revision to a commit SHA
michelengelen Aug 26, 2024
b67700b
added state_reason check to only run this on "completed" issues
michelengelen Aug 26, 2024
8382256
added closing reason to stackoverflow workflow to prevent closing mes…
michelengelen Aug 26, 2024
0dde9b5
Merge remote-tracking branch 'refs/remotes/upstream/master' into auto…
michelengelen Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/closed-issue-message.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
name: Add closing message to issue

on:
issues:
types:
- closed
workflow_call:

permissions: {}

jobs:
add-comment:
name: Add closing message
if: github.event.issue.state_reason == 'completed'
uses: mui/mui-public/.github/workflows/reusable/add-closing-message-to-issue.yml@04275a99fe10cee127ee417b8a872cfebc7d08e7
permissions:
contents: read
issues: write
1 change: 1 addition & 0 deletions .github/workflows/support-stackoverflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,5 @@ jobs:
If you have a question on Stack Overflow, you are welcome to link to it here, it might help others.
If your issue is subsequently confirmed as a bug, and the report follows the issue template, it can be reopened.
close-issue: true
issue-close-reason: 'not planned'
Copy link
Member

@mnajdova mnajdova Aug 26, 2024 •
edited by oliviertassinari
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what needed to be checked, nice!

Copy link
Member

@oliviertassinari oliviertassinari Aug 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should roll this change to all the other repositories, right? I imagine it's about https://github.blog/changelog/2022-05-19-the-new-github-issues-may-19th-update/.

I'm also not sure how to feel about not asking for support feedback on an issue we closed as not planned. I guess it makes sense, what we would get is mostly people not happy 😄. Kind of https://www.oesterlund.dev/blog/learnings-from-one-year-of-building-an-open-source-project#learning-2-dont-even-try-to-please-everyone, built a system that makes us default to not try to please everyone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the plan is to roll this out to all repos that have at least some user visibility.

lock-issue: false
Loading