[material-ui][SpeedDialAction] Add slots and slotProps #45065
+267
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai6855
changed the title
sai6855
added
component: speed dial
Netlify deploy previewhttps://deploy-preview-45065--material-ui.netlify.app/ @material-ui/core: parsed: +0.09% , gzip: +0.07% Bundle size reportDetails of bundle changes (Toolpad) |
This comment was marked as outdated.
This comment was marked as outdated.
|
@siriwatknp PR is ready for review |
siriwatknp
reviewed
Jan 23, 2025
| shouldForwardComponentProp: true, | ||
| className: clsx(classes.fab, className), | ||
| additionalProps: { | ||
| style: { |
There was a problem hiding this comment.
Suggested change
| style: { | |
| style: transitionStyle |
No need to spread the FabProps.style, the slotProps.fab.style (from FabProps) will be merged by useSlot.
siriwatknp
reviewed
Jan 23, 2025
Comment on lines
+212
to
+213
| onClose: handleTooltipClose, | ||
| onOpen: handleTooltipOpen, |
There was a problem hiding this comment.
These should goes into getSlotProps, so that slotProps.tooltip.onOpen does not replace the handleTooltipClose.
elementType: Tooltip,
externalForwardedProps,
shouldForwardComponentProp: true,
ref,
getSlotProps: (handlers) => ({
onClose: () => {
handlers.onClose?.(),
handleTooltipClose(),
},
onOpen: …
})
siriwatknp
reviewed
Jan 23, 2025
| expectedClassName: classes.fab, | ||
| testWithElement: null, | ||
| testWithComponent: CustomButton, | ||
| }, |
If you don't mind, can you do it directly in this PR? |
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #41281
This PR adds
fab,tooltip,staticTooltip,staticTooltipLabelslots, I'll deprecate tooltip* props in seperate PR