Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[materal-ui][SpeedDialAction] Propogate className to SpeedDialActionStaticTooltip if tooltipOpenProp is true #45066

Closed
wants to merge 2 commits into from

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Jan 20, 2025

If toolTipOpen is set to true, SpeedDialActionStaticTooltip becomes the root component. Since it is the root component, any value passed to className should be applied to SpeedDialActionStaticTooltip. However, this is not the case in the current implementation. As seen on line 198, className is not being attached. This PR addresses and fixes the issue.

Once this PR is merged, CI for this PR should turn to green #45065

return (
<SpeedDialActionStaticTooltip
id={id}
ref={ref}
className={classes.staticTooltip}
ownerState={ownerState}
{...other}

@sai6855 sai6855 added bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jan 20, 2025
@mui-bot
Copy link

mui-bot commented Jan 20, 2025

Netlify deploy preview

https://deploy-preview-45066--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 60436af

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the className should be added to SpeedDialActionStaticTooltip as it's already used by SpeedDialActionFab.

This could break some app.

@sai6855
Copy link
Contributor Author

sai6855 commented Jan 21, 2025

I don't think the className should be added to SpeedDialActionStaticTooltip as it's already used by SpeedDialActionFab.

This could break some app.

Ah got it, I'm closing this PR. Now #45065 is ready for review

@sai6855 sai6855 closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: speed dial This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants