Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Remove createStyleSheet #7740

Merged
merged 1 commit into from
Aug 12, 2017
Merged

[core] Remove createStyleSheet #7740

merged 1 commit into from
Aug 12, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 12, 2017 •
edited
Loading

Closes #7636

-import { withStyles, createStyleSheet } from 'material-ui/styles';
+import { withStyles } from 'material-ui/styles';

-const styleSheet = createStyleSheet('Button', {
+const styles = {
  root: {
    background: 'red',
  },
-});
+};

// ...

-export default withStyles(styleSheet)(AppContent);
+export default withStyles(styles, { name: 'Button' })(Button);
  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari merged commit 8ba45ba into mui:v1-beta Aug 12, 2017
@oliviertassinari oliviertassinari deleted the remove-createStyleSheet branch August 12, 2017 10:14
sebald pushed a commit to PTW-Freiburg/material-ui that referenced this pull request Aug 15, 2017
Merge remote-tracking branch 'upstream/v1-beta' into setup-typings-tests
1cab76e 
* upstream/v1-beta: (24 commits)
  v1.0.0-beta.5
  Update CHANGELOG.md
  [CHANGELOG] Prepare v1.0.0-beta.5
  chore(package): update size-limit to version 0.9.0 (mui#7757)
  [docs] Fix yarn docs:build script (mui#7745)
  [docs] Update the readme
  [Radio] Fix accessibility issue (mui#7742)
  [Tabs][BottomNavigation] Use value over index property (mui#7741)
  [core] Remove createStyleSheet (mui#7740)
  [core] Start simplifying styling API (mui#7730)
  [LinearProgress] Use transform instead width (mui#7732)
  Fix Typo (mui#7736)
  Documentation Fix - Fixing up the README documentation (mui#7733)
  [ButtonBase] Expose internal component (mui#7727)
  [Popover] Refactor popover transition - separation of concerns (mui#7720)
  Button documentation fix (mui#7726)
  Update supported-components.md (mui#7722)
  chore(package): update webpack to version 3.5.3 (mui#7723)
  [flow] flow type transitions Slide, Fade, Collapse (fixes)
  Create CODE_OF_CONDUCT.md
  ...
@bwalsh bwalsh mentioned this pull request Aug 16, 2017
Merged
@vyrotek vyrotek mentioned this pull request Aug 16, 2017
Merged
13 tasks
@sebald sebald mentioned this pull request Aug 17, 2017
Merged
6 tasks
sebald pushed a commit that referenced this pull request Aug 17, 2017
[typescript] Update withStyles to be compatible with beta.5
a98bbe7 
Ref #7740
iquabius added a commit to iquabius/olimat that referenced this pull request Aug 17, 2017
@iquabius
Refactor: change wrapping strategy for theming
0dee25f 
With example from Next.js:

  - vercel/next.js@58c2d13

And some API changes that happened yesterday (MUI is still in beta):

  - https://github.com/callemall/material-ui/releases/tag/v1.0.0-beta.5
  - mui/material-ui#7730
  - mui/material-ui#7740
sebald added a commit that referenced this pull request Aug 18, 2017
@sebald
[typescript] Update typings for beta.4 and beta.5 (#7793)
5e98ee2 
- Update `<Tabs>` API to match BC introduced in #7741
- Update `withStyle` API to match BC introduced in #7740
- Remove discriminated unions (microsoft/TypeScript#17882)
@oliviertassinari oliviertassinari mentioned this pull request Aug 18, 2017
Merged
Izhaki
Izhaki reviewed Aug 21, 2017
View reviewed changes
Copy link
Contributor

@Izhaki Izhaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm..

docs/src/pages/customization/css-in-js.md
class MyComponent extends Component {
render () {
return <div />;
return <div className={this.classes.root} />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right? this.props.classes.root?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to fix the docs? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure can. But tomorrow.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#7867

docs/src/pages/customization/css-in-js.md
class MyComponent extends Component {
render () {
return <div />;
return <div className={this.classes.root} />;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

alexhayes added a commit to alexhayes/material-ui that referenced this pull request Sep 7, 2017
@alexhayes
[stepper] Remove createStyleSheet as per mui#7740 (mui#4977)
56881ee
@alexhayes alexhayes mentioned this pull request Sep 7, 2017
Closed
4 tasks
alexhayes added a commit to alexhayes/material-ui that referenced this pull request Sep 7, 2017
@alexhayes
[stepper] Remove createStyleSheet as per mui#7740 (mui#4799)
da57767
alexhayes added a commit to alexhayes/material-ui that referenced this pull request Sep 12, 2017
@alexhayes
[stepper] Remove createStyleSheet as per mui#7740 (mui#4799)
671e160
alexhayes added a commit to alexhayes/material-ui that referenced this pull request Sep 20, 2017
@alexhayes
[stepper] Remove createStyleSheet as per mui#7740 (mui#4799)
66fbb0d
alexhayes added a commit to alexhayes/material-ui that referenced this pull request Sep 20, 2017
@alexhayes
[stepper] Remove createStyleSheet as per mui#7740 (mui#4799)
0cde00a
alexhayes added a commit to alexhayes/material-ui that referenced this pull request Oct 2, 2017
@alexhayes
[stepper] Remove createStyleSheet as per mui#7740 (mui#4799)
58b60fe
alexhayes added a commit to alexhayes/material-ui that referenced this pull request Oct 2, 2017
@alexhayes
[stepper] Remove createStyleSheet as per mui#7740 (mui#4799)
6c1ad10
alexhayes added a commit to alexhayes/material-ui that referenced this pull request Oct 8, 2017
@alexhayes
[stepper] Remove createStyleSheet as per mui#7740 (mui#4799)
67353a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Izhaki Izhaki Izhaki left review comments

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviertassinari @Izhaki