[docs] Fix missing props in css-in-js examples #7867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`this.classes.root` wouldn't work - `this.props.classes.root' would.
oliviertassinari
approved these changes
Aug 22, 2017
|
@Izhaki Thank you! |
rosskevin
pushed a commit
to alienfast/material-ui
that referenced
this pull request
Aug 23, 2017
* [docs] Fix missing props in css-in-js examples `this.classes.root` wouldn't work - `this.props.classes.root' would. * Update css-in-js.md
sebald
pushed a commit
that referenced
this pull request
Aug 23, 2017
* [docs] Fix missing props in css-in-js examples `this.classes.root` wouldn't work - `this.props.classes.root' would. * Update css-in-js.md
sebald
pushed a commit
that referenced
this pull request
Aug 23, 2017
* v1-beta: (23 commits) [docs] Fix missing props in css-in-js examples (#7867) [docs] Small fixes after the next.js refactorization (#7851) [docs] Fix release script v2 [docs] Fix release script v1.0.0-beta.6 [CHANGELOG] Prepare v1.0.0-beta.6 [docs] Some last improvement before the release (#7847) [docs] Show inherited components (#7846) [docs] Add a team page (#7842) [docs] Add a ROADMAP page (#7840) [TextField] Fix placeholder issue (#7838) [core] Better usage of the CI 🚀 (#7833) [RadioGroup] Rename selectedValue to value (#7832) [docs] Use next.js (#7759) [core] Update some dependencies (#7831) [icons] Release v1.0.0-beta.5 [icons] Fix release [docs] Advanced table (#7824) [icons] Automate release process (#7823) [core] Fix size-limit warning (#7822) ... # Conflicts: # docs/src/pages/demos/badges/badges.md # docs/src/pages/demos/cards/cards.md # docs/src/pages/demos/selection-controls/selection-controls.md # docs/src/pages/demos/stepper/stepper.md # pages/api/app-bar.md # pages/api/avatar.md # pages/api/badge.md # pages/api/bottom-navigation-button.md # pages/api/bottom-navigation.md # pages/api/button-base.md # pages/api/button.md # pages/api/card-actions.md # pages/api/card-content.md # pages/api/card-header.md # pages/api/card-media.md # pages/api/card.md # pages/api/checkbox.md # pages/api/chip.md # pages/api/circular-progress.md # pages/api/collapse.md # pages/api/dialog-actions.md # pages/api/dialog-content.md # pages/api/dialog-title.md # pages/api/dialog.md # pages/api/divider.md # pages/api/drawer.md # pages/api/fade.md # pages/api/form-control-label.md # pages/api/form-control.md # pages/api/form-group.md # pages/api/form-helper-text.md # pages/api/form-label.md # pages/api/grid-list-tile-bar.md # pages/api/grid-list-tile.md # pages/api/grid-list.md # pages/api/grid.md # pages/api/grow.md # pages/api/hidden.md # pages/api/icon-button.md # pages/api/icon.md # pages/api/input-label.md # pages/api/input.md # pages/api/linear-progress.md # pages/api/list-item-avatar.md # pages/api/list-item-icon.md # pages/api/list-item-secondary-action.md # pages/api/list-item-text.md # pages/api/list-item.md # pages/api/list-subheader.md # pages/api/list.md # pages/api/menu-item.md # pages/api/menu-list.md # pages/api/menu.md # pages/api/mobile-stepper.md # pages/api/mui-theme-provider.md # pages/api/paper.md # pages/api/radio-group.md # pages/api/radio.md # pages/api/snackbar-content.md # pages/api/snackbar.md # pages/api/svg-icon.md # pages/api/switch.md # pages/api/tab.md # pages/api/table-body.md # pages/api/table-cell.md # pages/api/table-head.md # pages/api/table-row.md # pages/api/table-sort-label.md # pages/api/table.md # pages/api/tabs.md # pages/api/text-field.md # pages/api/toolbar.md # pages/api/typography.md # typings/index.d.ts
rosskevin
added a commit
that referenced
this pull request
Aug 23, 2017
* [flow] upgrade flow-bin * [flow] initial flow-upgrade - ran flow-upgrade - switch React.Element<any> references to React.Node - switch all react imports to `* as React` and use the React.* for access to uniformly access both function and types - linted * [flow] flow-typed install * [flow] flow-typed workaround marked libdef flow-typed/flow-typed#1165 * [flow] flow-upgrade ./test * [flow] fix flow usage of WebkitTran* * [flow] type single-only children for transitions * [flow] woohoo, resolved sticky Snackbar flow typing * [flow] more 53.1 typing * [Card] flow fixes #7854 * [flow] more flow 53.1 * [flow] fixme for #7868 * [flow] 53.1 ./examples * [flow] weak type docs for 53.1 * [flow] flow-typed workaround for flow-typed/flow-typed#1158 * [flow] workaround for flow-typed/flow-typed#1158 * [flow] require Dialog element * [flow] convert withStyles to flow * [flow] workaround brigand/babel-plugin-flow-react-proptypes#127 This isn’t a fix, it just gets past the error. I assume generated prop types are still invalid. * [flow] type TouchRipple and Ripple * [flow] type withTheme * [flow] type HOC withTheme * [flow] bind hoc BaseProps * [flow] type withWidth * [flow] type Tabs * [flow] correct requirements for HOC props * [flow] 0.53.1 conversion - tests finally run with a few errors * [flow] FormControl children were tested as optional * [Textarea] revert to target instead of currentTarget * [docs] Fix missing props in css-in-js examples (#7867) * [docs] Fix missing props in css-in-js examples `this.classes.root` wouldn't work - `this.props.classes.root' would. * Update css-in-js.md * [flow] get docs working * [Tabs] fix flow change that broke tab movement * [flow] reduce DefaultProps usage to the minimum necessary * [flow] type callback on ButtonBase * [docs] workaround react-docgen #7780 * Temporary size limit increase due to #7881
oliviertassinari
pushed a commit
that referenced
this pull request
Aug 23, 2017
* [typescript] Add test for style overrides. * [typescript] Refactor typings to modules ...instead of ambient modules. * renamed the styleSheet argument in withStyles to styles (#7819) * [typescript] Create typings for TS when building. (#7820) * [core] Fix size-limit warning (#7822) * [icons] Automate release process (#7823) * [docs] Advanced table (#7824) * [icons] Fix release * [icons] Release v1.0.0-beta.5 * [core] Update some dependencies (#7831) * [icons] Update the dependencies * [core] Update some dependencies * [docs] Use next.js (#7759) * [RadioGroup] Rename selectedValue to value (#7832) * [core] Better usage of the CI 🚀 (#7833) * [TextField] Fix placeholder issue (#7838) * [docs] Add a ROADMAP page (#7840) * [docs] Add a team page (#7842) * [docs] Show inherited components (#7846) * [docs] Some last improvement before the release (#7847) * [CHANGELOG] Prepare v1.0.0-beta.6 * v1.0.0-beta.6 * [docs] Fix release script * [docs] Fix release script v2 * [docs] Small fixes after the next.js refactorization (#7851) * [docs] Fix missing props in css-in-js examples (#7867) * [docs] Fix missing props in css-in-js examples `this.classes.root` wouldn't work - `this.props.classes.root' would. * Update css-in-js.md * [typescript] Fix tests. * [build] Copy .d.ts files to build folder. * [typescript] Create module typings for icons. * [typescript] Lint.
Taldrain
pushed a commit
to Taldrain/material-ui
that referenced
this pull request
Aug 24, 2017
* [typescript] Add test for style overrides. * [typescript] Refactor typings to modules ...instead of ambient modules. * renamed the styleSheet argument in withStyles to styles (mui#7819) * [typescript] Create typings for TS when building. (mui#7820) * [core] Fix size-limit warning (mui#7822) * [icons] Automate release process (mui#7823) * [docs] Advanced table (mui#7824) * [icons] Fix release * [icons] Release v1.0.0-beta.5 * [core] Update some dependencies (mui#7831) * [icons] Update the dependencies * [core] Update some dependencies * [docs] Use next.js (mui#7759) * [RadioGroup] Rename selectedValue to value (mui#7832) * [core] Better usage of the CI 🚀 (mui#7833) * [TextField] Fix placeholder issue (mui#7838) * [docs] Add a ROADMAP page (mui#7840) * [docs] Add a team page (mui#7842) * [docs] Show inherited components (mui#7846) * [docs] Some last improvement before the release (mui#7847) * [CHANGELOG] Prepare v1.0.0-beta.6 * v1.0.0-beta.6 * [docs] Fix release script * [docs] Fix release script v2 * [docs] Small fixes after the next.js refactorization (mui#7851) * [docs] Fix missing props in css-in-js examples (mui#7867) * [docs] Fix missing props in css-in-js examples `this.classes.root` wouldn't work - `this.props.classes.root' would. * Update css-in-js.md * [typescript] Fix tests. * [build] Copy .d.ts files to build folder. * [typescript] Create module typings for icons. * [typescript] Lint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.classes.rootwouldn't work - `this.props.classes.root' would.