[DataGrid] Remove legacy filtering API #10897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherniavskii
added
breaking change
component: data grid
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Wanna fix the conflicts before we review? |
github-actions
bot
removed
the
PR: out-of-date
romgrk
reviewed
Nov 8, 2023
Comment on lines
+12
to
+19
| function Toolbar() { | ||
| return ( | ||
| <div> | ||
| <GridToolbarFilterButton /> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Curious, why do we wrap in an additional div now?
There was a problem hiding this comment.
I didn't like the filter button expanding on full width here 😅
https://mui.com/x/react-data-grid/filtering/customization/
romgrk
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10581
TODO:
getApplyFilterFnV7togetApplyFilterFngetApplyQuickFilterFnV7togetApplyQuickFilterFn